Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AO] Add alertDetailsUrl field to the default action message of all the observability rule types #157284

Closed
4 tasks done
maryam-saeidi opened this issue May 10, 2023 · 1 comment · Fixed by #159571
Closed
4 tasks done
Assignees
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented May 10, 2023

📝 Summary

To make our default action messages actionable, we need to include an alertDetailsUrl link in the default action messages of the observability rules. This can be done after implementing #156534

Related to this request for APM rule types: #156498

Blocker

Spreadsheet

Default action and recovery messages and the proposed changes

✅ Acceptance Criteria

  • Include the alertDetailsUrl link to the default action message of the observability rule types
  • Cleanup getAlertDetailsConfig function
@maryam-saeidi maryam-saeidi added Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0 labels May 10, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/actionable-observability (Team: Actionable Observability)

@maryam-saeidi maryam-saeidi self-assigned this Jun 5, 2023
maryam-saeidi added a commit that referenced this issue Jun 14, 2023
…le types (#159571)

Closes #157284, closes #158437

## Summary

This PR updates the default action and recovery message for
observability rule types. Only uptime is excluded in this PR, I will add
that after synching with the synthetics team.


[Here](https://docs.google.com/spreadsheets/d/15cJanv0xi4EKo1QZVXsi_NcFcPa_VQze3nQc4P8GZrQ/edit?pli=1#gid=0)
you can find the list of default messages and the new proposals.

![image](https://github.com/elastic/kibana/assets/12370520/4f36e971-d8c2-47a9-ac25-9cae567db774)

## 🧪 How to test
- Ensure that `server.publicBaseUrl` is configured in kibana.dev.yml
- Create an observability rule with an action such as Email to use the
default messages (both for alert and recover states)
- After an alert is triggered, check the generated action message, it
should
   - match the message mentioned in the list
- contain an alert details link pointing to the Alerts page filtered for
that specific alert

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge" v8.9.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants