Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controls take too long to load for dataviews with huge no of fields #155452

Closed
bhavyarm opened this issue Apr 20, 2023 · 4 comments · Fixed by #155454
Closed

Controls take too long to load for dataviews with huge no of fields #155452

bhavyarm opened this issue Apr 20, 2023 · 4 comments · Fixed by #155454
Assignees
@Heenawter
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@bhavyarm
Copy link
Contributor

Kibana version: 8.7.1 BC2

Elasticsearch version: 8.7.1 BC2

Server OS version: darwin_aarch

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging on local

Describe the bug: Found while testing this PR - #154004. Controls take too long to load (a bit more than 7 seconds ) for dataviews with huge no of fields.

Please create a dataview with test data ingested from Hannah's script , create a dataview and make it default dataview.
Go to dashboard and try to add control.

node scripts/es_archiver load test/functional/fixtures/es_archiver/large_fields --es-url=http://elastic:changeme@localhost:9200/ --kibana-url=http://elastic:changeme@localhost:5601/
controls_panel.mp4
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Apr 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@bhavyarm
Copy link
Contributor Author

cc @Heenawter

@Heenawter Heenawter mentioned this issue Apr 20, 2023
Merged
@Heenawter
Copy link
Contributor

Heenawter commented Apr 20, 2023 •
edited
Loading

After investigating, I found that this was because another related PR was not backported to 8.7 - so, we were only seeing half of the performance improvements. Once this PR is backported, everything will work as expected 💃

@Heenawter Heenawter self-assigned this Apr 20, 2023
@Heenawter Heenawter linked a pull request Apr 20, 2023 that will close this issue
[8.7] [Controls] Use EUI Selectable for Field search (#151231) #155454
Merged
Heenawter added a commit that referenced this issue Apr 20, 2023
@Heenawter @ThomThomson
[8.7] [Controls] Use EUI Selectable for Field search (#151231) (#155454)
cc16f95 
Closes #155452

# Backport

This will backport the following commits from `main` to `8.7`:
- [[Controls] Use EUI Selectable for Field search
(#151231)](#151231)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Devon
Thomson","email":"devon.thomson@elastic.co"},"sourceCommit":{"committedDate":"2023-02-24T15:39:15Z","message":"[Controls]
Use EUI Selectable for Field search (#151231)\n\n## Summary\r\nReplaces
Control field selection list with
EUISelectable.","sha":"eb9cc11a7c81073a75fb3e6ec33e61796cc40aff","branchLabelMapping":{"^v8.8.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","Feature:Dashboard","Feature:Input
Control","Team:Presentation","loe:days","impact:low","backport:skip","v8.8.0"],"number":151231,"url":"https://github.com/elastic/kibana/pull/151231","mergeCommit":{"message":"[Controls]
Use EUI Selectable for Field search (#151231)\n\n## Summary\r\nReplaces
Control field selection list with
EUISelectable.","sha":"eb9cc11a7c81073a75fb3e6ec33e61796cc40aff"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.8.0","labelRegex":"^v8.8.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/151231","number":151231,"mergeCommit":{"message":"[Controls]
Use EUI Selectable for Field search (#151231)\n\n## Summary\r\nReplaces
Control field selection list with
EUISelectable.","sha":"eb9cc11a7c81073a75fb3e6ec33e61796cc40aff"}}]}]
BACKPORT-->

---------

Co-authored-by: Devon Thomson <devon.thomson@elastic.co>
@Heenawter
Copy link
Contributor

Closed by #155454 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Heenawter Heenawter

Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[8.7] [Controls] Use EUI Selectable for Field search (#151231) Heenawter/kibana
3 participants
@bhavyarm @Heenawter @elasticmachine