Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] DFA creation wizard: timefield mapping from source index doesn't get passed to destination index data view #155432

Closed
alvarezmelissa87 opened this issue Apr 20, 2023 · 1 comment · Fixed by #155669
Closed

[ML] DFA creation wizard: timefield mapping from source index doesn't get passed to destination index data view #155432

alvarezmelissa87 opened this issue Apr 20, 2023 · 1 comment · Fixed by #155669
Assignees
@alvarezmelissa87
Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml v8.8.0

Comments

@alvarezmelissa87
Copy link
Contributor

Describe the bug:

When creating a data frame analytics job there is no way to indicate the timefield for the resulting destination index when a dataview is created for it.

Steps to reproduce:

  1. Navigate to Machine Learning > Data Frame Analytics and create a new job using a source index with a mapped time field
  2. Go through the steps of the wizard and create a destination index with a dataview
  3. Once the job runs you can see the data view does not contain the timefield

Expected behavior:
There should be a way to indicate a timefield for the destination index like there is in the Transforms wizard

image
@alvarezmelissa87 alvarezmelissa87 added bug Fixes for quality problems that affect the customer experience :ml Feature:Data Frame Analytics ML data frame analytics features labels Apr 20, 2023
@alvarezmelissa87 alvarezmelissa87 self-assigned this Apr 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

This was referenced Apr 20, 2023
Closed
Merged
Merged
alvarezmelissa87 added a commit that referenced this issue Apr 25, 2023
@alvarezmelissa87
[ML] DFA creation wizard: add ability to add time field to result dat…
3b515a7 
…a view (#155669)

## Summary

Fixes #155432

This PR
- adds a timefield dropdown allowing user to select a timefield for the
result dataview
- defaults the timefield to that of the source data view (if one exists)


<img width="971" alt="image"
src="https://user-images.githubusercontent.com/6446462/234129267-0640651d-e5a6-4886-871b-a3298cd1285b.png">

<img width="1021" alt="image"
src="https://user-images.githubusercontent.com/6446462/234129299-ce970930-40d4-49e6-b627-7ecbc3c8e4a4.png">

### Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] Any UI touched in this PR is usable by keyboard only (learn more
about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [ ] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [ ] This was checked for [cross-browser
compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvarezmelissa87 alvarezmelissa87

Labels
bug Fixes for quality problems that affect the customer experience Feature:Data Frame Analytics ML data frame analytics features :ml v8.8.0
Projects
None yet
Milestone
No milestone
2 participants
@alvarezmelissa87 @elasticmachine