-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Actionable Observability] - Make the fields of the AlertSummary component dynamic. #147078
Closed
Tracked by
#138645
Labels
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.8.0
Comments
fkanout
added
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.7.0
labels
Dec 6, 2022
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
17 tasks
2 tasks
fkanout
added a commit
that referenced
this issue
Mar 8, 2023
β¦152443) ## Summary It closes #147078 [UPDATED SCREENSHOT] include the APM Latency rule-specific fields. <img width="1162" alt="Screenshot 2023-03-06 at 11 52 25" src="https://user-images.githubusercontent.com/6838659/223090293-d8853aed-c787-47b5-81a6-4491fb3edba8.png"> ## For APM reviewers - Not all alerts share the same fields/data (based on the rule definition). The [alert_details_app_section.tsx](https://github.com/elastic/kibana/pull/152443/files#diff-9ce6d23c878801afca7932bd0e272492b79931d51d8e61361d9bc56bf581657d) page of each rule will use the `setAlertSummaryFields` callback function (introduced in this PR) to send fields that are needed to be shown on the AlertSummay. The AlertSummary will show these rule-specific fields alongside the five basic/shared fields across all the rule types. - π I refactored the code. Now each chart lives in its separate file with its related hooks. - Added **Service name** and **Service environment** to the AlertSummary ## For Actionable Observability reviewers The AlertSummary component is now dynamic. It means it accepts additional fields to be shown via a new prop and combines them with the five basic/shared fields across all the rule types. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
bmorelli25
pushed a commit
to bmorelli25/kibana
that referenced
this issue
Mar 10, 2023
β¦lastic#152443) ## Summary It closes elastic#147078 [UPDATED SCREENSHOT] include the APM Latency rule-specific fields. <img width="1162" alt="Screenshot 2023-03-06 at 11 52 25" src="https://user-images.githubusercontent.com/6838659/223090293-d8853aed-c787-47b5-81a6-4491fb3edba8.png"> ## For APM reviewers - Not all alerts share the same fields/data (based on the rule definition). The [alert_details_app_section.tsx](https://github.com/elastic/kibana/pull/152443/files#diff-9ce6d23c878801afca7932bd0e272492b79931d51d8e61361d9bc56bf581657d) page of each rule will use the `setAlertSummaryFields` callback function (introduced in this PR) to send fields that are needed to be shown on the AlertSummay. The AlertSummary will show these rule-specific fields alongside the five basic/shared fields across all the rule types. - π I refactored the code. Now each chart lives in its separate file with its related hooks. - Added **Service name** and **Service environment** to the AlertSummary ## For Actionable Observability reviewers The AlertSummary component is now dynamic. It means it accepts additional fields to be shown via a new prop and combines them with the five basic/shared fields across all the rule types. ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Team: Actionable Observability - DEPRECATED
For Observability Alerting and SLOs use "Team:obs-ux-management", for AIops "Team:obs-knowledge"
v8.8.0
π Summary
Part of #138645
Depends on #145409
Make the
AlertSummary
component fields dynamic. i.e. accept the fields asprops
.β AC
{label: "Source", value: "server_source"}
Started
,Duration
,Last status update
,Rule Tags
, andStatus
.The text was updated successfully, but these errors were encountered: