Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] Add a way to filter rules on enabled or disabled state #132497

Closed
aarju opened this issue May 19, 2022 · 2 comments · Fixed by #150153
Closed

[Security Solution] Add a way to filter rules on enabled or disabled state #132497

aarju opened this issue May 19, 2022 · 2 comments · Fixed by #150153
Assignees
@maximpn
Labels
8.7 candidate enhancement New value added to drive a business result Feature:Rule Management Security Solution Detection Rule Management area needs design Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.

Comments

@aarju
Copy link

aarju commented May 19, 2022

Describe the feature:

Within the Security Application's Rules Management page there should be an easy way to filter the display to show and select only the enabled or disabled rules.

Describe a specific use case for the feature:
Scenario 1: My manager asked me how many custom rules we have currently enabled on our SIEM. To find that answer I would select the custom rules and then filter to only display the enabled rules. Then I could easily see the answer to the question in the Showing X Rules field of the table.

Scenario 2: I need to add a tag in all currently disabled rules so I would use this filter to only show the disabled rules, then select all and do a bulk update of the tags.
@botelastic botelastic bot added the needs-team Issues missing a team label label May 19, 2022
@banderror banderror added Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Feature:Rule Management Security Solution Detection Rule Management area Team:Detection Rule Management Security Detection Rule Management Team and removed needs-team Issues missing a team label labels May 19, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@banderror banderror changed the title [Security][Rules Management] Add a way to filter rules on enabled or disabled state [Security Solution] Add a way to filter rules on enabled or disabled state Nov 24, 2022
@banderror banderror added the enhancement New value added to drive a business result label Dec 29, 2022
@maximpn maximpn mentioned this issue Feb 2, 2023
Merged
7 tasks
@banderror banderror linked a pull request Feb 3, 2023 that will close this issue
[Security Solution] Add an enable or disabled state rules filter #150153
Merged
7 tasks
maximpn added a commit that referenced this issue Feb 4, 2023
@maximpn
[Security Solution] Add an enable or disabled state rules filter (#15…
949cb58 
…0153)

**Addresses:** #132497

## Summary

This PR adds a rules table filter for the enabled and disabled state.

*Filter in action*:

https://user-images.githubusercontent.com/3775283/216316405-27ad8b21-6392-4705-8af8-53c746a00acf.mov

Since the added filter occupies some space the search field may shrink too much. To address this issue wrapping was enabled for the filter row.

*Layout responsiveness:*

https://user-images.githubusercontent.com/3775283/216380837-3bda2072-4f5b-4754-8e57-8978c5e2b0d5.mov

### Checklist

- [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials
- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [x] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
- [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
@banderror banderror mentioned this issue Feb 21, 2023
Closed
4 tasks
@joepeeples joepeeples mentioned this issue Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximpn maximpn

Labels
8.7 candidate enhancement New value added to drive a business result Feature:Rule Management Security Solution Detection Rule Management area needs design Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Security Solution] Add an enable or disabled state rules filter maximpn/kibana
4 participants
@maximpn @banderror @aarju @elasticmachine