-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Data Frame Analytics: Enhancements for results view #131551
Labels
Comments
Pinging @elastic/ml-ui (:ml) |
8 tasks
alvarezmelissa87
added a commit
that referenced
this issue
Nov 8, 2022
…harts (#144354) ## Summary Related meta issue: #131551 In this PR support is added for selecting/highlighting an area in one scatterplot chart highlighting the corresponding area in the rest of the charts. - adds `user_selection` to spec - adds `user_selection` condition in `encoding` `color` to ensure highlighting in corresponding area of other charts - outlier and user selection (by drag or single point click) are now different colors #### Classification results: <img width="929" alt="image" src="https://user-images.githubusercontent.com/6446462/200012485-18cee3f9-8180-4727-894c-6d8376678c03.png"> #### Classification job wizard: <img width="928" alt="image" src="https://user-images.githubusercontent.com/6446462/200013588-2445f475-274c-4548-bcc3-4af4d631a6c4.png"> #### Outlier Detections results: <img width="969" alt="image" src="https://user-images.githubusercontent.com/6446462/200036149-4491ea6e-77a5-4c1b-9ddc-386d8a492f69.png"> #### Outlier Detection job wizard: <img width="938" alt="image" src="https://user-images.githubusercontent.com/6446462/200036269-b3b8ce39-6956-4bf9-b7ff-f61eb2022ae8.png"> #### Regression results: <img width="922" alt="image" src="https://user-images.githubusercontent.com/6446462/200013085-248eff9a-09f5-42a3-ac11-c2bfc3c08cf4.png"> #### Regression job wizard: <img width="944" alt="image" src="https://user-images.githubusercontent.com/6446462/200013485-0c54808c-2cc2-44e6-bc6d-bb1c3825cbe8.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
8 tasks
alvarezmelissa87
added a commit
that referenced
this issue
Nov 15, 2022
…rts (#144871) ## Summary Related meta issue: #131551 This PR adds functionality to the scatterplot charts to show the full data sample and, when the user has added a filter/query in the query bar, the portion of the data reflecting the filter is highlighted so it can be differentiated from the background data. Classification results view with query for `AvgTicketPrice > 400` <img width="1032" alt="image" src="https://user-images.githubusercontent.com/6446462/200716771-b2012e9b-c620-46a8-9dc3-92df23ef4476.png"> Outlier detection results view with same filter <img width="1026" alt="image" src="https://user-images.githubusercontent.com/6446462/200716858-01407906-34de-43d6-892b-7bbfede05eac.png"> Regression results view with same filter <img width="1007" alt="image" src="https://user-images.githubusercontent.com/6446462/200716910-41165b81-a300-420c-8976-47a0ea9612bf.png"> Help text: <img width="1005" alt="image" src="https://user-images.githubusercontent.com/6446462/201484563-9f4ca87b-3025-485f-ac0e-4a30deee847f.png"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
8 tasks
alvarezmelissa87
added a commit
that referenced
this issue
Jan 31, 2023
…ions for viewing scatterplot charts (#149647) ## Summary This PR adds a link to the custom visualization UI from scatterplot matrix charts in the data frame analytics job wizard and results views. This allows you to view the data and edit the visualization inside the custom visualization editor, and then save it to a dashboard to explore the data alongside other contextual information. <img width="884" alt="image" src="https://user-images.githubusercontent.com/7405507/215125288-9d5527fa-6074-42bd-98f1-2c04cd025432.png"> Related meta issue: #131551 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
kqualters-elastic
pushed a commit
to kqualters-elastic/kibana
that referenced
this issue
Feb 6, 2023
…ions for viewing scatterplot charts (elastic#149647) ## Summary This PR adds a link to the custom visualization UI from scatterplot matrix charts in the data frame analytics job wizard and results views. This allows you to view the data and edit the visualization inside the custom visualization editor, and then save it to a dashboard to explore the data alongside other contextual information. <img width="884" alt="image" src="https://user-images.githubusercontent.com/7405507/215125288-9d5527fa-6074-42bd-98f1-2c04cd025432.png"> Related meta issue: elastic#131551 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
This was referenced Feb 6, 2023
Open
Closed
Closing this in lieu of individual issues opened for each item for 8.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Enhancements for DFA outlier detection results view:
Scatterplot matrix
The scatterplot matrix charts should always show the full data sample and, when the user has added a filter/query in the query bar, the portion of the data reflecting the filter should be highlighted so it can be differentiated from the background data
Selecting/highlighting an area in one scatterplot chart should highlight the corresponding area in the rest of the charts. For reference, a Vega scatterplot matrix example can be found here. Note that the example is v5 and the scatterplot matrix we create is v4 so we need to find out if we can apply that approach of brushing to our version. The code that generates the Vega scatterplot code uses
getScatterplotMatrixVegaLiteSpec()
and lives here.For scatterplot selection, show an option to apply selection filter to entire page (can add to the url and then it will be reflected in the table as well) - this will ensure it's reflected in the table as well.
Add ability to drill down from a value in a column of the table (typically the field identifying the entity) to a visualization which is filtered to that value.
Add ability to add scatterplot matrix charts to a dashboard. Here is a python utility that creates the JSON structure for a raw Kibana saved object that includes the Vega chart as a Kibana visualization. Note however that it has been suggested to use a higher level API within Kibana to create a visualization (https://www.elastic.co/guide/en/kibana/8.2/saved-objects-api-create.html#saved-objects-api-create-example)
Add ability to link to custom visualizations (vega) page and view scatterplot charts there ***
Add control to change colors (accessibility issue)
There is no cross probing between the small multiples and the table: if you select a point in the chart or table you want to see it highlighted in the table and the charts.
Histogram charts
The text was updated successfully, but these errors were encountered: