Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service groups: When groups are enabled rename the Services routes #130960

Closed
formgeist opened this issue Apr 26, 2022 · 3 comments · Fixed by #131381
Closed

[APM] Service groups: When groups are enabled rename the Services routes #130960

formgeist opened this issue Apr 26, 2022 · 3 comments · Fixed by #131381
Assignees
@kpatticha
Labels
apm:service-groups bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:APM - DEPRECATED Use Team:obs-ux-infra_services.

Comments

@formgeist
Copy link
Contributor

Summary

Since introducing the new Service groups capability in APM which is currently an experimental feature, we should consider what impact it has on the routing when the feature is made generally available.

Proposal

The Services route can remain but we need to change the "Services" route to "All services" because it's now another group.

localhost_5601_ekx_app_apm_service-groups_comparisonEnabled=true rangeFrom=now-15m rangeTo=now

localhost_5601_ekx_app_apm_service-groups_comparisonEnabled=true rangeFrom=now-15m rangeTo=now (1)

Another change would be to add Service groups to the Global search results so "All services" will show as an option alongside the other groups. Related issue #128612

CleanShot 2022-04-26 at 12 16 20@2x
@formgeist formgeist added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. enhancement New value added to drive a business result apm:service-groups labels Apr 26, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@formgeist formgeist mentioned this issue Apr 26, 2022
Closed
@dannycroft dannycroft added the bug Fixes for quality problems that affect the customer experience label May 2, 2022
@kpatticha
Copy link
Contributor

@formgeist one clarification. Do we want to rename Services -> All Service even when the service groups feature is disable?

@kpatticha kpatticha self-assigned this May 3, 2022
@formgeist
Copy link
Contributor Author

@kpatticha No, only when the Service groups feature is enabled.

@kpatticha kpatticha mentioned this issue May 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpatticha kpatticha

Labels
apm:service-groups bug Fixes for quality problems that affect the customer experience enhancement New value added to drive a business result Team:APM - DEPRECATED Use Team:obs-ux-infra_services.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Rename service groups template titles and links kpatticha/kibana
4 participants
@dannycroft @kpatticha @formgeist @elasticmachine