Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Bug: Service group "All services" shows "Services" in the page title #128613

Closed
formgeist opened this issue Mar 28, 2022 · 5 comments
Closed
Labels
apm:service-groups bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.2.0

Comments

@formgeist
Copy link
Contributor

Kibana version:

8.2.0-SNAPSHOT

Describe the bug:

The dynamic service group "All services" shows "Services" in the page title although the group name is All services. This is also confusing when looking at the search result in the global search bar in Kibana.

CleanShot 2022-03-28 at 14 17 06@2x

CleanShot 2022-03-28 at 14 24 05

Steps to reproduce:

  1. Enable the Service groups feature in Advanced settings
  2. Create a service group first
  3. Go to the All services group in the groups view
  4. Notice the page title - then search for services in the global search bar and the links are also named similar.

Expected behavior:

I'd expect the All services group to be showing All services in the page title and the route name e.g. links in the global search results.

@formgeist formgeist added bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.2.0 labels Mar 28, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@gbamparop
Copy link
Contributor

This has been fixed by https://github.com/elastic/kibana/pull/128411/files#diff-44391dc521f639b32c0d04a77ab21c995adbb13998ee12e41064bde0d23ac234L265. @formgeist could you confirm if this is the intended behaviour?

@formgeist
Copy link
Contributor Author

@gbamparop It sorted out the weird naming, but I think we have to make a change to replace the Services route to Service groups and add entries for Service groups in the global search results, so the "All services" group will show once you've enabled the Service groups feature. I can open a new enhancement issue to figure this out.

@gbamparop
Copy link
Contributor

@formgeist sounds good!

@formgeist
Copy link
Contributor Author

I opened #130960 to follow up to this and fix the group naming for All services. We can close this particular issue now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apm:service-groups bug Fixes for quality problems that affect the customer experience Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v8.2.0
Projects
None yet
Development

No branches or pull requests

3 participants