Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security Solution] UI is distorted when warning message is displayed under rule execution logs #129321

Closed
ghost opened this issue Apr 4, 2022 · 8 comments · Fixed by #129752
Closed

[Security Solution] UI is distorted when warning message is displayed under rule execution logs #129321

ghost opened this issue Apr 4, 2022 · 8 comments · Fixed by #129752
Assignees
@spong
Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Monitoring Security Solution Detection Rule Monitoring area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0

Comments

@ghost
Copy link

ghost commented Apr 4, 2022

Describe the bug
UI is distorted when warning message is displayed under rule execution logs

Build Details:

Version: 8.2.0 BC1
Commit:d18a093a2cf03991b93ea3de6a1054d580d3e82f
Build:51685

preconditions

  1. Rule should be exist
  2. More than 1000 enteries should be exist under rule execution logs tab

Steps to Reproduce

  1. Navigate to rule page
  2. Click on above created rule
  3. Navigate to rule execution logs tab
  4. Observe that Updated <10 seconds> ago is displayed above the "show matric toggle"

Actual Result
UI is distorted when warning message is displayed under rule execution logs

Expected Result
UI should not be distorted when warning message is displayed under rule execution logs

Screen-Shot

image
@ghost ghost added bug Fixes for quality problems that affect the customer experience triage_needed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0 labels Apr 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@manishgupta-qasource
Copy link

Reviewed & assigned to @MadameSheema

@MadameSheema MadameSheema added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Detections and Resp Security Detection Response Team Team:Detection Rule Management Security Detection Rule Management Team and removed impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. labels Apr 4, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

@MadameSheema MadameSheema assigned spong and banderror and unassigned MadameSheema Apr 4, 2022
@spong
Copy link
Member

spong commented Apr 4, 2022

Will be resolved once #129003 is merged

@peluja1012 peluja1012 added the Feature:Rule Monitoring Security Solution Detection Rule Monitoring area label Apr 4, 2022
@spong spong mentioned this issue Apr 5, 2022
Merged
12 tasks
spong added a commit that referenced this issue Apr 5, 2022
@spong
[Security Solution][Detections] Rule Execution Log Feedback and Fixes (…
bc413c6 
…#129003)

## Summary

Addresses feedback and fixes identified in #126215

Feedback addressed includes:
* Adds route validation via io-ts decode and schema tests
* Fixed styling of max execution events error by wrapping text (#129321)
* Fixed types within `view alerts for execution` action onClick
* Caps auto-refresh minimum to `1min` (#129332)
* Adds cardinality aggs to initial `execution_uuid` query to properly report total counts when filtering by status
* Disabled `View Alerts from Execution` action as current UX was too cumbersome with erasing users existing filters

---
Additional follow-ups for another PR:
- [ ] UI Unit tests
- [ ] Finalize API Integration tests for gap remediation events
- [ ] Persist table state (DatePicker/StatusFilter/SortField/SortOrder/Pagination) when navigating to other tabs on the same page
- [ ] Update global DatePicker to daterange of execution for `view alerts for execution` action (and clear all other filters)
- [ ] Support `disabled rule` platform error #126215 (comment)
- [ ] Verify StatusFilter issue #126215 (comment)

---
### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
kibanamachine pushed a commit that referenced this issue Apr 5, 2022
@spong
[Security Solution][Detections] Rule Execution Log Feedback and Fixes (…
89e700a 
…#129003)

## Summary

Addresses feedback and fixes identified in #126215

Feedback addressed includes:
* Adds route validation via io-ts decode and schema tests
* Fixed styling of max execution events error by wrapping text (#129321)
* Fixed types within `view alerts for execution` action onClick
* Caps auto-refresh minimum to `1min` (#129332)
* Adds cardinality aggs to initial `execution_uuid` query to properly report total counts when filtering by status
* Disabled `View Alerts from Execution` action as current UX was too cumbersome with erasing users existing filters

---
Additional follow-ups for another PR:
- [ ] UI Unit tests
- [ ] Finalize API Integration tests for gap remediation events
- [ ] Persist table state (DatePicker/StatusFilter/SortField/SortOrder/Pagination) when navigating to other tabs on the same page
- [ ] Update global DatePicker to daterange of execution for `view alerts for execution` action (and clear all other filters)
- [ ] Support `disabled rule` platform error #126215 (comment)
- [ ] Verify StatusFilter issue #126215 (comment)

---
### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

(cherry picked from commit bc413c6)
kibanamachine added a commit that referenced this issue Apr 5, 2022
@kibanamachine @spong
[Security Solution][Detections] Rule Execution Log Feedback and Fixes (…
20fee3a 
…#129003) (#129518)

## Summary

Addresses feedback and fixes identified in #126215

Feedback addressed includes:
* Adds route validation via io-ts decode and schema tests
* Fixed styling of max execution events error by wrapping text (#129321)
* Fixed types within `view alerts for execution` action onClick
* Caps auto-refresh minimum to `1min` (#129332)
* Adds cardinality aggs to initial `execution_uuid` query to properly report total counts when filtering by status
* Disabled `View Alerts from Execution` action as current UX was too cumbersome with erasing users existing filters

---
Additional follow-ups for another PR:
- [ ] UI Unit tests
- [ ] Finalize API Integration tests for gap remediation events
- [ ] Persist table state (DatePicker/StatusFilter/SortField/SortOrder/Pagination) when navigating to other tabs on the same page
- [ ] Update global DatePicker to daterange of execution for `view alerts for execution` action (and clear all other filters)
- [ ] Support `disabled rule` platform error #126215 (comment)
- [ ] Verify StatusFilter issue #126215 (comment)

---
### Checklist

Delete any items that are not applicable to this PR.

- [X] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [X] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
- [X] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/))
- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

(cherry picked from commit bc413c6)

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
@ghost
Copy link
Author

ghost commented Apr 7, 2022

Hi @spong ,

We have validated this issue on 8.2.0 BC2 and observed that issue is Still Occurring

Please find below the testing details:

Build Details:

Version : 8.2.0 BC2
Build : 51772
Commit : 3535a206838845689639344afaf64a58c663b3c1

Screenshot

image

Thanks!!

@banderror banderror removed the fixed label Apr 7, 2022
@banderror banderror removed their assignment Apr 7, 2022
@spong spong mentioned this issue Apr 7, 2022
Merged
1 task
@spong
Copy link
Member

spong commented Apr 7, 2022

Sorry about that @deepikakeshav-qasource -- should now be addressed in #129752

spong added a commit that referenced this issue Apr 7, 2022
@spong
[Security Solution][Detections] Fixes utility bar text overflow issue…
a27ae07 
… on Rule Execution Log (#129752)

## Summary

Resolves #129321 (comment)

#### Before:
<p align="center">
  <img width="700" src="https://user-images.githubusercontent.com/2946766/162233704-2d321bd0-bde8-4d3a-942a-9155138fffed.png" />
</p>


#### After:
<p align="center">
  <img width="700" src="https://user-images.githubusercontent.com/2946766/162219564-22fc4158-f2d8-4e5b-bf64-50dcc4034260.gif" />
</p>




### Checklist

Delete any items that are not applicable to this PR.

- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))
kibanamachine pushed a commit that referenced this issue Apr 7, 2022
@spong
[Security Solution][Detections] Fixes utility bar text overflow issue…
208a7fc 
… on Rule Execution Log (#129752)

## Summary

Resolves #129321 (comment)

#### Before:
<p align="center">
  <img width="700" src="https://user-images.githubusercontent.com/2946766/162233704-2d321bd0-bde8-4d3a-942a-9155138fffed.png" />
</p>

#### After:
<p align="center">
  <img width="700" src="https://user-images.githubusercontent.com/2946766/162219564-22fc4158-f2d8-4e5b-bf64-50dcc4034260.gif" />
</p>

### Checklist

Delete any items that are not applicable to this PR.

- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

(cherry picked from commit a27ae07)
@spong
Copy link
Member

spong commented Apr 7, 2022

Re-opening for QA validation

@spong spong reopened this Apr 7, 2022
kibanamachine added a commit that referenced this issue Apr 7, 2022
@kibanamachine @spong
[Security Solution][Detections] Fixes utility bar text overflow issue…
3d04936 
… on Rule Execution Log (#129752) (#129775)

## Summary

Resolves #129321 (comment)

#### Before:
<p align="center">
  <img width="700" src="https://user-images.githubusercontent.com/2946766/162233704-2d321bd0-bde8-4d3a-942a-9155138fffed.png" />
</p>

#### After:
<p align="center">
  <img width="700" src="https://user-images.githubusercontent.com/2946766/162219564-22fc4158-f2d8-4e5b-bf64-50dcc4034260.gif" />
</p>

### Checklist

Delete any items that are not applicable to this PR.

- [X] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

(cherry picked from commit a27ae07)

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
@banderror banderror added the fixed label Apr 7, 2022
@ghost
Copy link
Author

ghost commented Apr 14, 2022

Hi Team,

We have validated this issue on 8.2.0 BC3 and observed that issue is Fixed 🟢

Please find below the testing details:

Build Details:

Version : 8.2.0 BC3
Build : 51885
Commit : 2ea6dc82752506d6f7aa34bda747f99c6fbfd152

Screenshot

image

Hence, We are closing this is issue and marking as QA Validated

Thanks!!

@ghost ghost added the QA:Validated Issue has been validated by QA label Apr 14, 2022
@ghost ghost closed this as completed Apr 14, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spong spong

Labels
bug Fixes for quality problems that affect the customer experience Feature:Rule Monitoring Security Solution Detection Rule Monitoring area fixed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. QA:Validated Issue has been validated by QA Team:Detection Rule Management Security Detection Rule Management Team Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.2.0
Projects
None yet
Milestone
No milestone
6 participants
@peluja1012 @spong @banderror @elasticmachine @MadameSheema @manishgupta-qasource