You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If you are in the discovery interface and using the keyboard to navigate, you'll find that you can (rightly) tab to the "show field settings" gear button, and the screen reader will (rightly) read "Show field settings"
However, once you open the field settings it still reads "show field settings." This should read "hide field settings" at this point to indicate that the extra UI can be hidden again.
The text was updated successfully, but these errors were encountered:
aria-expanded is a true/false/undefined state so we need to make sure
even if showFilter is undefined, we will print false (that's why the
double negation)
aria-haspopup doesn't really fit, since this is not a popup in the sense
the ARIA standard describes ("A popup is generally presented visually as
a group of items that appears to be on top of the main page content.")
Add aria-controls to reference the controlled element.
Fixelastic#12638 and toggle label when filter toggles
If you are in the discovery interface and using the keyboard to navigate, you'll find that you can (rightly) tab to the "show field settings" gear button, and the screen reader will (rightly) read "Show field settings"
However, once you open the field settings it still reads "show field settings." This should read "hide field settings" at this point to indicate that the extra UI can be hidden again.
The text was updated successfully, but these errors were encountered: