Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Show field settings button accessibility can be improved #12638

Closed
aphelionz opened this issue Jul 1, 2017 · 0 comments
Closed
Assignees

Comments

@aphelionz
Copy link
Contributor

If you are in the discovery interface and using the keyboard to navigate, you'll find that you can (rightly) tab to the "show field settings" gear button, and the screen reader will (rightly) read "Show field settings"

image

However, once you open the field settings it still reads "show field settings." This should read "hide field settings" at this point to indicate that the extra UI can be hidden again.

@timroes timroes self-assigned this Jul 6, 2017
timroes added a commit to timroes/kibana that referenced this issue Jul 6, 2017
aria-expanded is a true/false/undefined state so we need to make sure
even if showFilter is undefined, we will print false (that's why the
double negation)

aria-haspopup doesn't really fit, since this is not a popup in the sense
the ARIA standard describes ("A popup is generally presented visually as
a group of items that appears to be on top of the main page content.")

Add aria-controls to reference the controlled element.

Fix elastic#12638 and toggle label when filter toggles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants