Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Remove apm_oss.indexPattern from the docs #114652

Closed
gbamparop opened this issue Oct 12, 2021 · 10 comments · Fixed by #114903 or #120025
Closed

[APM] Remove apm_oss.indexPattern from the docs #114652

gbamparop opened this issue Oct 12, 2021 · 10 comments · Fixed by #114903 or #120025
Assignees
Labels
bug Fixes for quality problems that affect the customer experience docs Team:APM All issues that need APM UI Team support Team:Docs v7.16.0

Comments

@gbamparop
Copy link
Contributor

Remove apm_oss.indexPattern from the documentation as it is no longer used.

image.png

@gbamparop gbamparop added [zube]: Inbox bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support labels Oct 12, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv changed the title Remove apm_oss.indexPattern from the dos [APM] Remove apm_oss.indexPattern from the docs Oct 12, 2021
@sorenlouv sorenlouv changed the title [APM] Remove apm_oss.indexPattern from the docs [APM] Remove apm_oss.indexPattern from the docs Oct 12, 2021
@gbamparop
Copy link
Contributor Author

Hi @bmorelli25, could you have a look at this issue please?

@bmorelli25
Copy link
Member

@gbamparop Just the apm_oss.indexPattern setting? Can you provide more context as to why this should be removed? We currently link to this setting in the APM API docs: Customize the APM index pattern.

@bmorelli25
Copy link
Member

bmorelli25 commented Oct 13, 2021

I see the setting was removed from the docs in #114139, and other settings were updated in #113364, but I'm still not sure what context is for this removal.

Should we only mention the Kibana update object API as a way to update the default APM index pattern? Or should the entire Customize the APM index pattern topic be removed?

@bmorelli25
Copy link
Member

Opened the two PRs ⬆️. Questions still stand but can be addressed in the PRs. Thanks for bringing this to my attention.

@gbamparop
Copy link
Contributor Author

gbamparop commented Oct 14, 2021

@bmorelli25 I think the sections related to this could be removed as the config is being constructed now by concatenating the specified indices. Please see #111133 for more context about the decision. @sqren what do you think?

@sorenlouv
Copy link
Member

sorenlouv commented Oct 14, 2021

Yes, what @gbamparop said. The index pattern is now automatically inferred from the indices so setting it manually is no longer needed (nor possible).

@bmorelli25
Copy link
Member

Thanks. Reopening this issue until Customize the APM index pattern is removed.

@bmorelli25 bmorelli25 reopened this Oct 14, 2021
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 14, 2021
@zube zube bot closed this as completed Oct 14, 2021
@zube zube bot added [zube]: Done and removed [zube]: Inbox labels Oct 14, 2021
@bmorelli25 bmorelli25 reopened this Oct 14, 2021
@zube zube bot added [zube]: Inbox and removed [zube]: Done labels Oct 14, 2021
@sorenlouv
Copy link
Member

@bmorelli25 I see your two PRs are merged. Can this be closed?

@bmorelli25
Copy link
Member

bmorelli25 commented Oct 28, 2021

Not yet! I still need to do this #114652 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience docs Team:APM All issues that need APM UI Team support Team:Docs v7.16.0
Projects
None yet
5 participants