Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Show edit/delete button while field stats are loading #106823

Closed
Tracked by #57706
timroes opened this issue Jul 27, 2021 · 1 comment · Fixed by #138899
Closed
Tracked by #57706

[Lens] Show edit/delete button while field stats are loading #106823

timroes opened this issue Jul 27, 2021 · 1 comment · Fixed by #138899
Assignees
@alexwizp
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure usability

Comments

@timroes
Copy link
Contributor

timroes commented Jul 27, 2021

When opening a field popover we currently show a loading spinner instead of any content in the popover while loading the distribution. This is especially annoying for runtime fields, where loading the stats takes quit some time, and you can't open the edit dialog (or press delete) while the loading still happens.

screenshot-20210727-105059

I suggest that we show the header of the dialog (containing the edit/delete/add buttons) already while loading the distrbution and just show a chart loading icon for the bottom part of the dialog while this is still loading.

That would allow users to quickly get to the edit dialog of their runtime field, especially if they are still working on the runtime field, and thus need to more often save it and edit it, and need to wait otherwise every time on the distribution data to be done loading.

cc @ghudgins @stratoula
@timroes timroes added enhancement New value added to drive a business result Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jul 27, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ghudgins ghudgins mentioned this issue Jul 27, 2021
Closed
@ghudgins ghudgins mentioned this issue Jun 1, 2022
Closed
@alexwizp alexwizp mentioned this issue Aug 16, 2022
Merged
@alexwizp alexwizp self-assigned this Aug 16, 2022
maryam-saeidi pushed a commit to maryam-saeidi/kibana that referenced this issue Aug 16, 2022
@alexwizp @kibanamachine
[Lens] Show edit/delete button while field stats are loading (elastic…
51dc347 
…#138899)

Closes elastic#106823

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this issue Aug 16, 2022
@alexwizp @kibanamachine @clintandrewhall
[Lens] Show edit/delete button while field stats are loading (elastic…
4003a0d 
…#138899)

Closes elastic#106823

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
clintandrewhall pushed a commit to clintandrewhall/kibana that referenced this issue Aug 16, 2022
@alexwizp @kibanamachine @clintandrewhall
[Lens] Show edit/delete button while field stats are loading (elastic…
c039a90 
…#138899)

Closes elastic#106823

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Mpdreamz pushed a commit to Mpdreamz/kibana that referenced this issue Sep 6, 2022
@alexwizp @kibanamachine @Mpdreamz
[Lens] Show edit/delete button while field stats are loading (elastic…
18d6fce 
…#138899)

Closes elastic#106823

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Lens] Show edit/delete button while field stats are loading alexwizp/kibana
4 participants
@timroes @ghudgins @elasticmachine @alexwizp