Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Use new package types in kbn-securitysolution-list-utils #105731

Closed
lizozom opened this issue Jul 15, 2021 · 2 comments · Fixed by #106801
Closed

[Security] Use new package types in kbn-securitysolution-list-utils #105731

lizozom opened this issue Jul 15, 2021 · 2 comments · Fixed by #106801
Assignees
@FrankHassanabad
Labels
enhancement New value added to drive a business result Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.0.0

Comments

@lizozom
Copy link
Contributor

lizozom commented Jul 15, 2021

In #100310 the package kbn-securitysolution-list-utils re-defined the IFieldType and IIndexPattern types to any as they couldn't import from the data plugin.

Once #103530 is merged, the package may use the IndexPatternBase and IndexPatternFieldBase types to remove this override and also simplify their code (those simplified types should be enough for the SIEM code)

type IFieldType = any;
type IIndexPattern = any;
@lizozom lizozom added triage_needed enhancement New value added to drive a business result v8.0.0 Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. labels Jul 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@FrankHassanabad FrankHassanabad self-assigned this Jul 15, 2021
@FrankHassanabad FrankHassanabad added the Team:Detections and Resp Security Detection Response Team label Jul 15, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detections-response (Team:Detections and Resp)

This was referenced Jul 22, 2021
Merged
Merged
FrankHassanabad added a commit that referenced this issue Jul 27, 2021
@FrankHassanabad
[Security Solutions] Removes deprecated types in kbn-securitysolution…
5dd68dd 
…-* for newer kbn-es-query types (#106801)

## Summary

Fixes #105731, by replacing these `any` types:

```json
type IFieldType = any;
type IIndexPattern = any;
type Filter = any;
```

With the types from `es-query` which are:
* IndexPatternFieldBase
* IndexPatternBase
* Filter

Note: I had to do a few creative casting to avoid having to use `FieldSpec` since that is not within the package `es-query` and is not planned to be within that package or another package for at least a while if ever.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jul 27, 2021
@FrankHassanabad @kibanamachine
[Security Solutions] Removes deprecated types in kbn-securitysolution…
3fa8c02 
…-* for newer kbn-es-query types (elastic#106801)

## Summary

Fixes elastic#105731, by replacing these `any` types:

```json
type IFieldType = any;
type IIndexPattern = any;
type Filter = any;
```

With the types from `es-query` which are:
* IndexPatternFieldBase
* IndexPatternBase
* Filter

Note: I had to do a few creative casting to avoid having to use `FieldSpec` since that is not within the package `es-query` and is not planned to be within that package or another package for at least a while if ever.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
kibanamachine added a commit that referenced this issue Jul 28, 2021
@kibanamachine @FrankHassanabad
[Security Solutions] Removes deprecated types in kbn-securitysolution…
f60b00b 
…-* for newer kbn-es-query types (#106801) (#106869)

## Summary

Fixes #105731, by replacing these `any` types:

```json
type IFieldType = any;
type IIndexPattern = any;
type Filter = any;
```

With the types from `es-query` which are:
* IndexPatternFieldBase
* IndexPatternBase
* Filter

Note: I had to do a few creative casting to avoid having to use `FieldSpec` since that is not within the package `es-query` and is not planned to be within that package or another package for at least a while if ever.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <frank.hassanabad@elastic.co>
streamich pushed a commit to vadimkibana/kibana that referenced this issue Aug 8, 2021
@FrankHassanabad @vadimkibana
[Security Solutions] Removes deprecated types in kbn-securitysolution…
6e319c8 
…-* for newer kbn-es-query types (elastic#106801)

## Summary

Fixes elastic#105731, by replacing these `any` types:

```json
type IFieldType = any;
type IIndexPattern = any;
type Filter = any;
```

With the types from `es-query` which are:
* IndexPatternFieldBase
* IndexPatternBase
* Filter

Note: I had to do a few creative casting to avoid having to use `FieldSpec` since that is not within the package `es-query` and is not planned to be within that package or another package for at least a while if ever.

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankHassanabad FrankHassanabad

Labels
enhancement New value added to drive a business result Team:Detections and Resp Security Detection Response Team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. triage_needed v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@FrankHassanabad @lizozom @elasticmachine