Skip to content

Commit

Permalink
Move VisEditorContructor to visualize
Browse files Browse the repository at this point in the history
  • Loading branch information
Tim Roes committed Oct 8, 2020
1 parent 2293a47 commit f581dc1
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 11 deletions.
11 changes: 1 addition & 10 deletions src/plugins/visualizations/public/vis_types/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,12 @@
*/

import { IconType } from '@elastic/eui';
import { EventEmitter } from 'events';
import React from 'react';
import { Adapters } from 'src/plugins/inspector';
import { IEditorController } from 'src/plugins/visualize/public';
import { VisEditorConstructor } from 'src/plugins/visualize/public';
import { ISchemas } from 'src/plugins/vis_default_editor/public';
import { TriggerContextMapping } from '../../../ui_actions/public';
import { Vis, VisToExpressionAst, VisualizationControllerConstructor } from '../types';
import { VisualizeEmbeddableContract } from '..';

export interface VisTypeOptions {
showTimePicker: boolean;
Expand All @@ -35,13 +33,6 @@ export interface VisTypeOptions {
hierarchicalData: boolean;
}

export type VisEditorConstructor = new (
element: HTMLElement,
vis: Vis,
eventEmitter: EventEmitter,
embeddableHandler: VisualizeEmbeddableContract
) => IEditorController;

/**
* A visualization type representing one specific type of "classical"
* visualizations (i.e. not Lens visualizations).
Expand Down
8 changes: 8 additions & 0 deletions src/plugins/visualize/public/application/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import { SharePluginStart } from 'src/plugins/share/public';
import { SavedObjectsStart, SavedObject } from 'src/plugins/saved_objects/public';
import { EmbeddableStart } from 'src/plugins/embeddable/public';
import { UrlForwardingStart } from 'src/plugins/url_forwarding/public';
import { EventEmitter } from 'events';
import { DashboardStart } from '../../../dashboard/public';

export type PureVisState = SavedVisState;
Expand Down Expand Up @@ -131,6 +132,13 @@ export interface ByValueVisInstance {

export type VisualizeEditorVisInstance = SavedVisInstance | ByValueVisInstance;

export type VisEditorConstructor = new (
element: HTMLElement,
vis: Vis,
eventEmitter: EventEmitter,
embeddableHandler: VisualizeEmbeddableContract
) => IEditorController;

export interface IEditorController {
render(props: EditorRenderProps): Promise<void> | void;
destroy(): void;
Expand Down
6 changes: 5 additions & 1 deletion src/plugins/visualize/public/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,11 @@
import { PluginInitializerContext } from 'kibana/public';
import { VisualizePlugin } from './plugin';

export { EditorRenderProps, IEditorController } from './application/types';
export type {
EditorRenderProps,
IEditorController,
VisEditorConstructor,
} from './application/types';
export { VisualizeConstants } from './application/visualize_constants';

export const plugin = (context: PluginInitializerContext) => {
Expand Down

0 comments on commit f581dc1

Please sign in to comment.