Skip to content

Commit

Permalink
Should not remove the uiSettings getter and setter
Browse files Browse the repository at this point in the history
  • Loading branch information
stratoula committed Jan 28, 2021
1 parent 58e28aa commit f57d222
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/plugins/visualize/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ import { SavedObjectsStart } from '../../saved_objects/public';
import { EmbeddableStart } from '../../embeddable/public';
import { DashboardStart } from '../../dashboard/public';
import type { SavedObjectTaggingOssPluginStart } from '../../saved_objects_tagging_oss/public';
import { setVisEditorsRegistry } from './services';
import { setVisEditorsRegistry, setUISettings } from './services';
import { createVisEditorsRegistry, VisEditorsRegistry } from './vis_editors_registry';

export interface VisualizePluginStartDependencies {
Expand Down Expand Up @@ -117,6 +117,8 @@ export class VisualizePlugin
stopUrlTracker();
};

setUISettings(core.uiSettings);

core.application.register({
id: 'visualize',
title: 'Visualize',
Expand Down
4 changes: 3 additions & 1 deletion src/plugins/visualize/public/services.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,12 @@
* compliance with, at your election, the Elastic License or the Server Side
* Public License, v 1.
*/

import { IUiSettingsClient } from '../../../core/public';
import { createGetterSetter } from '../../../plugins/kibana_utils/public';
import { VisEditorsRegistry } from './vis_editors_registry';

export const [getUISettings, setUISettings] = createGetterSetter<IUiSettingsClient>('UISettings');

export const [
getVisEditorsRegistry,
setVisEditorsRegistry,
Expand Down

0 comments on commit f57d222

Please sign in to comment.