Refresh snapshots, fix broken tests/types.

elastic · Apr 23, 2020 · ef21286 · ef21286
1 parent 0ddd97b
commit ef21286
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 8 deletions.
diff --git a/.../uptime/public/components/settings/__tests__/__snapshots__/certificate_form.test.tsx.snap b/.../uptime/public/components/settings/__tests__/__snapshots__/certificate_form.test.tsx.snap
diff --git a/...gins/uptime/public/components/settings/__tests__/__snapshots__/indices_form.test.tsx.snap b/...gins/uptime/public/components/settings/__tests__/__snapshots__/indices_form.test.tsx.snap
diff --git a/x-pack/plugins/uptime/server/lib/alerts/__tests__/status_check.test.ts b/x-pack/plugins/uptime/server/lib/alerts/__tests__/status_check.test.ts
@@ -88,9 +88,9 @@ describe('status check alert', () => {
           Object {
             "callES": [MockFunction],
             "dynamicSettings": Object {
-              "certificatesThresholds": Object {
+              "certThresholds": Object {
                 "age": 365,
-                "expiration": 7,
+                "expiration": 30,
               },
               "heartbeatIndices": "heartbeat-8*",
             },
@@ -135,9 +135,9 @@ describe('status check alert', () => {
           Object {
             "callES": [MockFunction],
             "dynamicSettings": Object {
-              "certificatesThresholds": Object {
+              "certThresholds": Object {
                 "age": 365,
-                "expiration": 7,
+                "expiration": 30,
               },
               "heartbeatIndices": "heartbeat-8*",
             },

diff --git a/x-pack/plugins/uptime/server/lib/requests/__tests__/get_certs.test.ts b/x-pack/plugins/uptime/server/lib/requests/__tests__/get_certs.test.ts
@@ -5,6 +5,7 @@
  */
 
 import { getCerts } from '../get_certs';
+import { DYNAMIC_SETTINGS_DEFAULTS } from '../../../../../../legacy/plugins/uptime/common/constants';
 
 describe('getCerts', () => {
   let mockHits: any;
@@ -86,7 +87,10 @@ describe('getCerts', () => {
   it('parses query result and returns expected values', async () => {
     const result = await getCerts({
       callES: mockCallES,
-      dynamicSettings: { heartbeatIndices: 'heartbeat*' },
+      dynamicSettings: {
+        heartbeatIndices: 'heartbeat*',
+        certThresholds: DYNAMIC_SETTINGS_DEFAULTS.certThresholds,
+      },
       index: 1,
       from: 'now-2d',
       to: 'now+1h',

diff --git a/x-pack/test/api_integration/apis/uptime/rest/dynamic_settings.ts b/x-pack/test/api_integration/apis/uptime/rest/dynamic_settings.ts
@@ -23,7 +23,7 @@ export default function({ getService }: FtrProviderContext) {
     it('can change the settings', async () => {
       const newSettings = {
         heartbeatIndices: 'myIndex1*',
-        certificatesThresholds: {
+        certThresholds: {
           expiration: 5,
           age: 15,
         },