fixed linting rules

elastic · Apr 1, 2022 · ec39aeb · ec39aeb
1 parent 8845913
commit ec39aeb
Show file tree

Hide file tree

Showing 6 changed files with 37 additions and 7 deletions.
diff --git a/x-pack/plugins/security_solution/public/common/components/landing_page/index.tsx b/x-pack/plugins/security_solution/public/common/components/landing_page/index.tsx
@@ -16,3 +16,5 @@ export const LandingPageComponent = memo(() => {
     </SecuritySolutionPageWrapper>
   );
 });
+
+LandingPageComponent.displayName = 'LandingPageComponent';
diff --git a/x-pack/plugins/security_solution/public/common/components/link_to/redirect_to_landing.tsx b/x-pack/plugins/security_solution/public/common/components/link_to/redirect_to_landing.tsx
@@ -7,5 +7,5 @@
 
 import { appendSearch } from './helpers';
 
-export const getAppLandingUrl = (overviewPath: string, search?: string) =>
-  `${overviewPath}${appendSearch(search)}`;
+export const getAppLandingUrl = (path: string, search?: string) =>
+  `${path}${appendSearch(search)}`;
diff --git a/x-pack/plugins/security_solution/public/hosts/pages/hosts.test.tsx b/x-pack/plugins/security_solution/public/hosts/pages/hosts.test.tsx
@@ -100,9 +100,17 @@ describe('Hosts - rendering', () => {
         </Router>
       </TestProviders>
     );
+
+  const getUrlForAppMock = (
+      appId: string,
+      options?: { deepLinkId?: string; path?: string; absolute?: boolean }
+    ) => `${appId}${options?.deepLinkId ? `/${options.deepLinkId}` : ''}${options?.path ?? ''}`;
+
+  const landingPath = getUrlForAppMock(APP_UI_ID, { deepLinkId: SecurityPageName.landing });
+
     expect(mockNavigateToApp).toHaveBeenCalledWith(APP_UI_ID, {
       deepLinkId: SecurityPageName.landing,
-      path: getAppLandingUrl(),
+      path: getAppLandingUrl(landingPath),
     });
   });
 

diff --git a/x-pack/plugins/security_solution/public/network/pages/network.test.tsx b/x-pack/plugins/security_solution/public/network/pages/network.test.tsx
@@ -26,7 +26,7 @@ import { Network } from './network';
 import { NetworkRoutes } from './navigation';
 import { mockCasesContract } from '../../../../cases/public/mocks';
 import { APP_UI_ID, SecurityPageName } from '../../../common/constants';
-import { getAppLandingUrl } from '../../common/components/link_to';
+import { getAppLandingUrl } from '../../common/components/link_to/redirect_to_landing';
 
 jest.mock('../../common/containers/sourcerer');
 
@@ -133,9 +133,16 @@ describe('Network page - rendering', () => {
       </TestProviders>
     );
 
+    const getUrlForAppMock = (
+      appId: string,
+      options?: { deepLinkId?: string; path?: string; absolute?: boolean }
+    ) => `${appId}${options?.deepLinkId ? `/${options.deepLinkId}` : ''}${options?.path ?? ''}`;
+
+    const landingPath = getUrlForAppMock(APP_UI_ID, { deepLinkId: SecurityPageName.landing });
+
     expect(mockNavigateToApp).toHaveBeenCalledWith(APP_UI_ID, {
       deepLinkId: SecurityPageName.landing,
-      path: getAppLandingUrl(SecurityPageName.landing),
+      path: getAppLandingUrl(landingPath),
     });
   });
 

diff --git a/x-pack/plugins/security_solution/public/overview/pages/overview.test.tsx b/x-pack/plugins/security_solution/public/overview/pages/overview.test.tsx
@@ -311,10 +311,16 @@ describe('Overview', () => {
             </MemoryRouter>
           </TestProviders>
         );
+        const getUrlForAppMock = (
+          appId: string,
+          options?: { deepLinkId?: string; path?: string; absolute?: boolean }
+        ) => `${appId}${options?.deepLinkId ? `/${options.deepLinkId}` : ''}${options?.path ?? ''}`;
+
+        const landingPath = getUrlForAppMock(APP_UI_ID, { deepLinkId: SecurityPageName.landing });
 
         expect(mockNavigateToApp).toHaveBeenCalledWith(APP_UI_ID, {
           deepLinkId: SecurityPageName.landing,
-          path: getAppLandingUrl(),
+          path: getAppLandingUrl(landingPath),
         });
       });
     });

diff --git a/x-pack/plugins/security_solution/public/users/pages/users_tabs.test.tsx b/x-pack/plugins/security_solution/public/users/pages/users_tabs.test.tsx
@@ -85,9 +85,16 @@ describe('Users - rendering', () => {
         </Router>
       </TestProviders>
     );
+    const getUrlForAppMock = (
+      appId: string,
+      options?: { deepLinkId?: string; path?: string; absolute?: boolean }
+    ) => `${appId}${options?.deepLinkId ? `/${options.deepLinkId}` : ''}${options?.path ?? ''}`;
+
+    const landingPath = getUrlForAppMock(APP_UI_ID, { deepLinkId: SecurityPageName.landing });
+
     expect(mockNavigateToApp).toHaveBeenCalledWith(APP_UI_ID, {
       deepLinkId: SecurityPageName.landing,
-      path: getAppLandingUrl(),
+      path: getAppLandingUrl(landingPath),
     });
   });
-Original file line number
+Diff line change
@@ Expand Up / @@ -16,3 +16,5 @@ export const LandingPageComponent = memo(() => { @@
         </SecuritySolutionPageWrapper>
       );
     });
+    LandingPageComponent.displayName = 'LandingPageComponent';