Skip to content

Commit

Permalink
support requesting reviews from specific users by package (#47246)
Browse files Browse the repository at this point in the history
  • Loading branch information
Spencer committed Oct 3, 2019
1 parent 8bdb20a commit ebb62cb
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 0 deletions.
11 changes: 11 additions & 0 deletions renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,17 @@
'(\\b|_)jest(\\b|_)',
],
},
{
groupSlug: '@elastic/charts',
groupName: '@elastic/charts related packages',
packageNames: [
'@elastic/charts',
'@types/elastic__charts',
],
reviewers: [
'markov00',
],
},
{
groupSlug: 'mocha',
groupName: 'mocha related packages',
Expand Down
1 change: 1 addition & 0 deletions src/dev/renovate/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ export const RENOVATE_CONFIG = {
labels: group.extraLabels && [...DEFAULT_LABELS, ...group.extraLabels],
enabled: group.enabled === false ? false : undefined,
allowedVersions: group.allowedVersions || undefined,
reviewers: group.reviewers || undefined,
})),

// internal/local packages
Expand Down
11 changes: 11 additions & 0 deletions src/dev/renovate/package_groups.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ interface PackageGroup {
* https://renovatebot.com/docs/configuration-options/#allowedversions
*/
readonly allowedVersions?: string;

/**
* An array of users to request reviews from
*/
readonly reviewers?: string[];
}

export const RENOVATE_PACKAGE_GROUPS: PackageGroup[] = [
Expand All @@ -75,6 +80,12 @@ export const RENOVATE_PACKAGE_GROUPS: PackageGroup[] = [
packageWords: ['jest'],
},

{
name: '@elastic/charts',
packageNames: ['@elastic/charts'],
reviewers: ['markov00'],
},

{
name: 'mocha',
packageWords: ['mocha'],
Expand Down

0 comments on commit ebb62cb

Please sign in to comment.