Skip to content

Commit

Permalink
feat: 🎸 add kibana.yml to disable in-chart "explore data" actio
Browse files Browse the repository at this point in the history
  • Loading branch information
streamich committed Jun 26, 2020
1 parent b567eb2 commit e4945cd
Show file tree
Hide file tree
Showing 4 changed files with 50 additions and 6 deletions.
5 changes: 3 additions & 2 deletions x-pack/plugins/discover_enhanced/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@
"id": "discoverEnhanced",
"version": "8.0.0",
"kibanaVersion": "kibana",
"server": false,
"server": true,
"ui": true,
"requiredPlugins": ["uiActions", "embeddable", "discover"],
"optionalPlugins": ["share"]
"optionalPlugins": ["share"],
"configPath": ["xpack", "discoverEnhanced"]
}
14 changes: 10 additions & 4 deletions x-pack/plugins/discover_enhanced/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,11 @@ export interface DiscoverEnhancedStartDependencies {
export class DiscoverEnhancedPlugin
implements
Plugin<void, void, DiscoverEnhancedSetupDependencies, DiscoverEnhancedStartDependencies> {
constructor(public readonly initializerContext: PluginInitializerContext) {}
public readonly config: { actions: { exploreDataInChart: { enabled: boolean } } };

constructor(protected readonly context: PluginInitializerContext) {
this.config = context.config.get();
}

setup(
core: CoreSetup<DiscoverEnhancedStartDependencies>,
Expand All @@ -68,9 +72,11 @@ export class DiscoverEnhancedPlugin
const exploreDataAction = new ExploreDataContextMenuAction(params);
uiActions.addTriggerAction(CONTEXT_MENU_TRIGGER, exploreDataAction);

const exploreDataChartAction = new ExploreDataChartAction(params);
uiActions.addTriggerAction(SELECT_RANGE_TRIGGER, exploreDataChartAction);
uiActions.addTriggerAction(VALUE_CLICK_TRIGGER, exploreDataChartAction);
if (this.config.actions.exploreDataInChart.enabled) {
const exploreDataChartAction = new ExploreDataChartAction(params);
uiActions.addTriggerAction(SELECT_RANGE_TRIGGER, exploreDataChartAction);
uiActions.addTriggerAction(VALUE_CLICK_TRIGGER, exploreDataChartAction);
}
}
}

Expand Down
25 changes: 25 additions & 0 deletions x-pack/plugins/discover_enhanced/server/config.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

import { schema, TypeOf } from '@kbn/config-schema';
import { PluginConfigDescriptor } from '../../../../src/core/server';

export const configSchema = schema.object({
actions: schema.object({
exploreDataInChart: schema.object({
enabled: schema.boolean({ defaultValue: true }),
}),
}),
});

export type ConfigSchema = TypeOf<typeof configSchema>;

export const config: PluginConfigDescriptor<ConfigSchema> = {
schema: configSchema,
exposeToBrowser: {
actions: true,
},
};
12 changes: 12 additions & 0 deletions x-pack/plugins/discover_enhanced/server/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*
* Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
* or more contributor license agreements. Licensed under the Elastic License;
* you may not use this file except in compliance with the Elastic License.
*/

export { config } from './config';

export const plugin = () => ({
setup() {},
start() {},
});

0 comments on commit e4945cd

Please sign in to comment.