Skip to content

Commit

Permalink
removed group setting from panel settings
Browse files Browse the repository at this point in the history
  • Loading branch information
Rashid Khan committed Jul 14, 2013
1 parent b8bca8b commit de8f8c5
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion config.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ var config = new Settings(
elasticsearch: "http://"+window.location.hostname+":9200",
// elasticsearch: 'http://localhost:9200',
kibana_index: "kibana-int",
modules: ['histogram','map','pie','table'
modules: ['histogram','map','pie','table',
'timepicker','text','fields','hits','dashcontrol',
'column','derivequeries','trends','bettermap','query'],
}
Expand Down
3 changes: 0 additions & 3 deletions partials/panelgeneral.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
<div class="span4">
<label class="small">Title</label><input type="text" class="input-medium" ng-model='panel.title'></input>
</div>
<div class="span4">
<label class="small">Group(s) (comma seperated)</label><input array-join type="text" class="input-medium" ng-model='panel.group'></input>
</div>
<div class="span2" ng-hide="panel.sizeable == false">
<label class="small">Span</label> <select class="input-mini" ng-model="panel.span" ng-options="f for f in [0,1,2,3,4,5,6,7,8,9,10,11,12]"></select>
</div>
Expand Down

2 comments on commit de8f8c5

@jsm-oxa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ho nooooo please T_T
This functionnality is totally great !
You just have to explain better how it works because indeed, at the beginning, It's very difficult to understand the effect of groups.
But as I know how it work, some of my dashboard have different group to separate the comportement of panels according to the query or the timepicker etc.

Moreover, as all panel can use multi query, there is no way to separate the comportement of a panel in the same dashboard by setting query in there editor ?

Consequently, all panel are linked, and one query panel or one timepicker to rule them all...

But if you keep the group feature, it possible to separate comportement by adding an other query or timepicker panel without causing trouble for the multi-query functionnality :) (and in my dashboards, I hide these additional panels)

It seems that the group is still present in the json (I exported to file), so we can conserve this functionnality if we just keep these lines in the panelgeneral.html...

Thank you and congratulation for these milestone pre3 =)

@jsm-oxa
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Rashid,

Can you tell me what are you intend to do with the group functionnality ?
At this moment, this feature prevents me to upgrade to the milestone pre3, and I would avoid to branch your master just because of this :)

For example, I have a main dashboard that display 2 histogram panels, one is binded to the main timepicker which is control other panels as pie, hits and trends, the other is binded to an hidden timepicker in an hidden row to display information in a larger time range with auto refresh.
Moreover, there are trends also binded to a specific timepicker in the same hidden row to control the autorefresh separatlty.

Thank you very much

Please sign in to comment.