Refactor per code review

- Remove stui classes - Inline status
elastic · Dec 1, 2020 · db239d7 · db239d7
1 parent beb9589
commit db239d7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 24 deletions.
diff --git a/.../plugins/enterprise_search/public/applications/shared/indexing_status/indexing_status.tsx b/.../plugins/enterprise_search/public/applications/shared/indexing_status/indexing_status.tsx
@@ -23,26 +23,22 @@ export interface IIndexingStatusProps extends IIndexingStatus {
   setGlobalIndexingStatus?(activeReindexJob: IIndexingStatus): void;
 }
 
-export const IndexingStatus: React.FC<IIndexingStatusProps> = (props) => {
-  const statusPanel = (percentComplete: number) => (
-    <EuiPanel paddingSize="l" hasShadow>
-      <IndexingStatusContent percentageComplete={percentComplete} />
-    </EuiPanel>
-  );
-
-  return (
-    <IndexingStatusFetcher {...props}>
-      {(percentageComplete, numDocumentsWithErrors) => (
-        <div className="c-stui-indexing-status-wrapper">
-          {percentageComplete < 100 && statusPanel(percentageComplete)}
-          {percentageComplete === 100 && numDocumentsWithErrors > 0 && (
-            <>
-              <EuiSpacer />
-              <IndexingStatusErrors viewLinkPath={props.viewLinkPath} />
-            </>
-          )}
-        </div>
-      )}
-    </IndexingStatusFetcher>
-  );
-};
+export const IndexingStatus: React.FC<IIndexingStatusProps> = (props) => (
+  <IndexingStatusFetcher {...props}>
+    {(percentageComplete, numDocumentsWithErrors) => (
+      <div>
+        {percentageComplete < 100 && (
+          <EuiPanel paddingSize="l" hasShadow>
+            <IndexingStatusContent percentageComplete={percentageComplete} />
+          </EuiPanel>
+        )}
+        {percentageComplete === 100 && numDocumentsWithErrors > 0 && (
+          <>
+            <EuiSpacer />
+            <IndexingStatusErrors viewLinkPath={props.viewLinkPath} />
+          </>
+        )}
+      </div>
+    )}
+  </IndexingStatusFetcher>
+);
diff --git a/...s/enterprise_search/public/applications/shared/indexing_status/indexing_status_errors.tsx b/...s/enterprise_search/public/applications/shared/indexing_status/indexing_status_errors.tsx
@@ -18,7 +18,6 @@ interface IIndexingStatusErrorsProps {
 
 export const IndexingStatusErrors: React.FC<IIndexingStatusErrorsProps> = ({ viewLinkPath }) => (
   <EuiCallOut
-    className="c-stui-indexing-status-errors"
     color="danger"
     iconType="cross"
     title="There was an error"