[PR feedback] Breadcrumb errors/fallbacks

elastic · Jun 18, 2021 · d77ee41 · d77ee41
1 parent 8bea24e
commit d77ee41
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/...ications/workplace_search/views/content_sources/components/add_source/add_source.test.tsx b/...ications/workplace_search/views/content_sources/components/add_source/add_source.test.tsx
@@ -87,6 +87,13 @@ describe('AddSourceList', () => {
     });
   });
 
+  it('renders a breadcrumb fallback while data is loading', () => {
+    setMockValues({ ...mockValues, dataLoading: true, sourceConfigData: {} });
+    const wrapper = shallow(<AddSource sourceIndex={1} />);
+
+    expect(wrapper.prop('pageChrome')).toEqual(['Sources', 'Add Source', '...']);
+  });
+
   it('renders Config Completed step', () => {
     setMockValues({
       ...mockValues,

diff --git a/.../applications/workplace_search/views/content_sources/components/add_source/add_source.tsx b/.../applications/workplace_search/views/content_sources/components/add_source/add_source.tsx
@@ -103,7 +103,7 @@ export const AddSource: React.FC<AddSourceProps> = (props) => {
   const Layout = isOrganization ? WorkplaceSearchPageTemplate : PersonalDashboardLayout;
 
   return (
-    <Layout pageChrome={[NAV.SOURCES, NAV.ADD_SOURCE, name]} isLoading={dataLoading}>
+    <Layout pageChrome={[NAV.SOURCES, NAV.ADD_SOURCE, name || '...']} isLoading={dataLoading}>
       {addSourceCurrentStep === AddSourceSteps.ConfigIntroStep && (
         <ConfigurationIntro name={name} advanceStep={goToSaveConfig} header={header} />
       )}

diff --git a/...rch/public/applications/workplace_search/views/settings/components/source_config.test.tsx b/...rch/public/applications/workplace_search/views/settings/components/source_config.test.tsx
@@ -40,6 +40,13 @@ describe('SourceConfig', () => {
     expect(wrapper.find(EuiConfirmModal)).toHaveLength(1);
   });
 
+  it('renders a breadcrumb fallback while data is loading', () => {
+    setMockValues({ dataLoading: true, sourceConfigData: {} });
+    const wrapper = shallow(<SourceConfig sourceIndex={1} />);
+
+    expect(wrapper.prop('pageChrome')).toEqual(['Settings', 'Content source connectors', '...']);
+  });
+
   it('handles delete click', () => {
     const wrapper = shallow(<SourceConfig sourceIndex={1} />);
     const saveConfig = wrapper.find(SaveConfig);

diff --git a/...e_search/public/applications/workplace_search/views/settings/components/source_config.tsx b/...e_search/public/applications/workplace_search/views/settings/components/source_config.tsx
@@ -47,7 +47,7 @@ export const SourceConfig: React.FC<SourceConfigProps> = ({ sourceIndex }) => {
 
   return (
     <WorkplaceSearchPageTemplate
-      pageChrome={[NAV.SETTINGS, NAV.SETTINGS_SOURCE_PRIORITIZATION, name]}
+      pageChrome={[NAV.SETTINGS, NAV.SETTINGS_SOURCE_PRIORITIZATION, name || '...']}
       isLoading={dataLoading}
     >
       <SaveConfig