test: 💍 add extra unit test for root embeddable type

elastic · Apr 30, 2020 · d72961b · d72961b
1 parent 17ebb52
commit d72961b
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/...blic/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.test.tsx b/...blic/services/drilldowns/actions/flyout_create_drilldown/flyout_create_drilldown.test.tsx
@@ -49,6 +49,7 @@ interface CompatibilityParams {
   isEdit?: boolean;
   isValueClickTriggerSupported?: boolean;
   isEmbeddableEnhanced?: boolean;
+  rootType?: string;
 }
 
 describe('isCompatible', () => {
@@ -59,6 +60,7 @@ describe('isCompatible', () => {
       isEdit = true,
       isValueClickTriggerSupported = true,
       isEmbeddableEnhanced = true,
+      rootType = 'dashboard',
     }: CompatibilityParams,
     expectedResult: boolean = true
   ): Promise<void> {
@@ -71,6 +73,8 @@ describe('isCompatible', () => {
       }
     );
 
+    embeddable.rootType = rootType;
+
     if (isEmbeddableEnhanced) {
       embeddable = enhanceEmbeddable(embeddable);
     }
@@ -106,6 +110,12 @@ describe('isCompatible', () => {
       isEdit: false,
     });
   });
+
+  test('not compatible if root embeddable is not "dashboard"', async () => {
+    await assertNonCompatibility({
+      rootType: 'visualization',
+    });
+  });
 });
 
 describe('execute', () => {

diff --git a/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/test_helpers.ts b/x-pack/plugins/dashboard_enhanced/public/services/drilldowns/actions/test_helpers.ts
@@ -15,6 +15,7 @@ import { TriggerContextMapping } from '../../../../../../../src/plugins/ui_actio
 import { uiActionsEnhancedPluginMock } from '../../../../../advanced_ui_actions/public/mocks';
 
 export class MockEmbeddable extends Embeddable {
+  public rootType = 'dashboard';
   public readonly type = 'mock';
   private readonly triggers: Array<keyof TriggerContextMapping> = [];
   constructor(
@@ -31,7 +32,7 @@ export class MockEmbeddable extends Embeddable {
   }
   public getRoot() {
     return {
-      type: 'dashboard',
+      type: this.rootType,
     } as Embeddable;
   }
 }