remove unused lifecycle methods

elastic · May 12, 2020 · d50f53b · d50f53b
1 parent 0b9f2fb
commit d50f53b
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 9 deletions.
diff --git a/x-pack/plugins/lens/public/datatable_visualization/index.ts b/x-pack/plugins/lens/public/datatable_visualization/index.ts
@@ -41,5 +41,4 @@ export class DatatableVisualization {
     );
     editorFrame.registerVisualization(datatableVisualization);
   }
-  start() {}
 }
diff --git a/x-pack/plugins/lens/public/pie_visualization/index.ts b/x-pack/plugins/lens/public/pie_visualization/index.ts
@@ -43,8 +43,4 @@ export class PieVisualization {
 
     editorFrame.registerVisualization(pieVisualization);
   }
-
-  start() {}
-
-  stop() {}
 }
diff --git a/x-pack/plugins/lens/public/plugin.ts b/x-pack/plugins/lens/public/plugin.ts
@@ -97,9 +97,6 @@ export class LensPlugin {
 
   start(core: CoreStart, startDependencies: LensPluginStartDependencies) {
     this.createEditorFrame = this.editorFrameService.start(core, startDependencies).createInstance;
-    this.xyVisualization.start();
-    this.datatableVisualization.start();
-    this.pieVisualization.start();
   }
 
   stop() {

diff --git a/x-pack/plugins/lens/public/xy_visualization/index.ts b/x-pack/plugins/lens/public/xy_visualization/index.ts
@@ -53,5 +53,4 @@ export class XyVisualization {
 
     editorFrame.registerVisualization(xyVisualization);
   }
-  start() {}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -41,5 +41,4 @@ export class DatatableVisualization { @@
         );
         editorFrame.registerVisualization(datatableVisualization);
       }
-      start() {}
     }