Apply JL's feedback: rename tsx->ts filetypes, fix typo, remove unuse…

…d TestSubjects type.

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/app/app.helpers.tsx

@@ -12,7 +12,6 @@ import { KibanaContextProvider } from '../../../../../../src/plugins/kibana_reac
 import { createBreadcrumbsMock } from '../../../public/application/services/breadcrumbs.mock';
 import { licensingMock } from '../../../../licensing/public/mocks';
 import { App } from '../../../public/application/app';
-import { TestSubjects } from '../helpers';
 
 const breadcrumbService = createBreadcrumbsMock();
 
@@ -37,7 +36,7 @@ const getTestBedConfig = (initialEntries: string[]): TestBedConfig => ({
 const initTestBed = (initialEntries: string[]) =>
   registerTestBed(AppWithContext, getTestBedConfig(initialEntries))();
 
-export interface AppTestBed extends TestBed<TestSubjects> {
+export interface AppTestBed extends TestBed {
   actions: {
     clickPolicyNameLink: () => void;
     clickCreatePolicyButton: () => void;

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/init_test_bed.tsx

@@ -15,7 +15,6 @@ import { EditPolicy } from '../../../public/application/sections/edit_policy';
 import { KibanaContextProvider } from '../../../public/shared_imports';
 import { AppServicesContext } from '../../../public/types';
 import { createBreadcrumbsMock } from '../../../public/application/services/breadcrumbs.mock';
-import { TestSubjects } from '../helpers';
 import { POLICY_NAME } from './constants';
 
 const getTestBedConfig = (testBedConfigArgs?: Partial<TestBedConfig>): TestBedConfig => {
@@ -52,8 +51,5 @@ export const initTestBed = (arg?: {
   testBedConfig?: Partial<TestBedConfig>;
 }) => {
   const { testBedConfig: testBedConfigArgs, ...rest } = arg || {};
-  return registerTestBed<TestSubjects>(
-    EditPolicyContainer,
-    getTestBedConfig(testBedConfigArgs)
-  )(rest);
+  return registerTestBed(EditPolicyContainer, getTestBedConfig(testBedConfigArgs))(rest);
 };

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/index.ts

@@ -5,7 +5,7 @@
  * 2.0.
  */
 
-export { TestSubjects, Phase } from './types';
+export { Phase } from './types';
 
 export { createNodeAllocationActions } from './create_node_allocation_actions';
 export { createEnablePhaseAction } from './create_enable_phase_action';

x-pack/plugins/index_lifecycle_management/__jest__/client_integration/helpers/types.ts

@@ -8,23 +8,3 @@
 import { Phases } from '../../../common/types';
 
 export type Phase = keyof Phases;
-
-export type TestSubjects =
-  | 'snapshotPolicyCombobox'
-  | 'savePolicyButton'
-  | 'customPolicyCallout'
-  | 'noPoliciesCallout'
-  | 'policiesErrorCallout'
-  | 'rolloverSwitch'
-  | 'rolloverSettingsRequired'
-  | 'hot-selectedMaxSizeStored'
-  | 'hot-selectedMaxSizeStoredUnits'
-  | 'hot-selectedMaxDocuments'
-  | 'hot-selectedMaxAge'
-  | 'hot-selectedMaxAgeUnits'
-  | 'policyTablePolicyNameLink'
-  | 'policyTitle'
-  | 'createPolicyButton'
-  | 'cold-freezeSwitch'
-  | 'frozen-freezeSwitch'
-  | string;

x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/data_tier_allocation_field/components/node_allocation.tsx

@@ -69,7 +69,7 @@ export const NodeAllocation: FunctionComponent<SharedProps> = ({
   let nodeAllocationOptions = [];
 
   // On Cloud, allocating to data tiers and allocating to data nodes is mutually exclusive. So we
-  // only let users select this option if they're using data nodes. Otherwise we remove it.r
+  // only let users select this option if they're using data nodes. Otherwise we remove it.
   //
   // On prem, users should have the freedom to choose this option, even if they're using node roles.
   // So we always give them this option.