chore(NA): fix types for kbn/interpreter migration

elastic · Jun 17, 2021 · d1209fe · d1209fe
1 parent 04b4927
commit d1209fe
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 4 deletions.
diff --git a/packages/kbn-interpreter/src/common/index.ts b/packages/kbn-interpreter/src/common/index.ts
@@ -17,6 +17,7 @@ export { Fn } from './lib/fn';
 export { getType } from './lib/get_type';
 export { castProvider } from './lib/cast';
 // @ts-expect-error
+// @internal
 export { parse } from '../../grammar';
 export { getByAlias } from './lib/get_by_alias';
 export { Registry } from './lib/registry';

diff --git a/packages/kbn-interpreter/src/common/lib/ast.ts b/packages/kbn-interpreter/src/common/lib/ast.ts
@@ -21,11 +21,13 @@ export interface ExpressionFunctionAST {
 }
 
 export interface Ast {
+  /** @internal */
   function: any;
+  /** @internal */
   arguments: any;
   type: 'expression';
   chain: ExpressionFunctionAST[];
-
+  /** @internal */
   replace(regExp: RegExp, s: string): string;
 }
 

diff --git a/packages/kbn-interpreter/tsconfig.json b/packages/kbn-interpreter/tsconfig.json
@@ -9,6 +9,7 @@
     "rootDir": "src",
     "sourceMap": true,
     "sourceRoot": "../../../../packages/kbn-interpreter/src",
+    "stripInternal": true,
     "types": [
       "jest",
       "node"

diff --git a/x-pack/plugins/canvas/public/functions/to.ts b/x-pack/plugins/canvas/public/functions/to.ts
@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-// @ts-expect-error untyped Elastic library
 import { castProvider } from '@kbn/interpreter/common';
 import { ExpressionFunctionDefinition } from 'src/plugins/expressions/public';
 import { getFunctionHelp, getFunctionErrors } from '../../i18n';

diff --git a/x-pack/plugins/canvas/public/registries.ts b/x-pack/plugins/canvas/public/registries.ts
@@ -5,7 +5,6 @@
  * 2.0.
  */
 
-// @ts-expect-error untyped module
 import { addRegistries, register } from '@kbn/interpreter/common';
 // @ts-expect-error untyped local
 import { elementsRegistry } from './lib/elements_registry';

diff --git a/x-pack/plugins/canvas/public/state/selectors/workpad.ts b/x-pack/plugins/canvas/public/state/selectors/workpad.ts
@@ -6,7 +6,6 @@
  */
 
 import { get, omit } from 'lodash';
-// @ts-expect-error untyped local
 import { safeElementFromExpression, fromExpression } from '@kbn/interpreter/common';
 import { append } from '../../lib/modify_path';
 import { getAssets } from './assets';