Skip to content

Commit

Permalink
fix: 🐛 import share plugin to check if it is enabled
Browse files Browse the repository at this point in the history
  • Loading branch information
streamich committed Jun 12, 2020
1 parent 5bddd7e commit ce45079
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
3 changes: 2 additions & 1 deletion x-pack/plugins/discover_enhanced/kibana.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,6 @@
"kibanaVersion": "kibana",
"server": false,
"ui": true,
"requiredPlugins": ["uiActions", "embeddable", "discover"]
"requiredPlugins": ["uiActions", "embeddable", "discover"],
"optionalPlugins": ["share"]
}
7 changes: 5 additions & 2 deletions x-pack/plugins/discover_enhanced/public/plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import { PluginInitializerContext } from 'kibana/public';
import { UiActionsSetup, UiActionsStart } from '../../../../src/plugins/ui_actions/public';
import { createStartServicesGetter } from '../../../../src/plugins/kibana_utils/public';
import { DiscoverSetup, DiscoverStart } from '../../../../src/plugins/discover/public';
import { SharePluginSetup, SharePluginStart } from '../../../../src/plugins/share/public';
import {
EmbeddableSetup,
EmbeddableStart,
Expand All @@ -24,14 +25,16 @@ declare module '../../../../src/plugins/ui_actions/public' {
}

export interface DiscoverEnhancedSetupDependencies {
discover: DiscoverSetup;
embeddable: EmbeddableSetup;
discover?: DiscoverSetup;
share?: SharePluginSetup;
uiActions: UiActionsSetup;
}

export interface DiscoverEnhancedStartDependencies {
discover: DiscoverStart;
embeddable: EmbeddableStart;
discover?: DiscoverStart;
share?: SharePluginStart;
uiActions: UiActionsStart;
}

Expand Down

0 comments on commit ce45079

Please sign in to comment.