remove unused code

elastic · Dec 2, 2022 · ce2aa16 · ce2aa16
1 parent 208a29e
commit ce2aa16
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 15 deletions.
diff --git a/...etection_engine/rule_exceptions/components/flyout_components/add_to_lists_table/index.tsx b/...etection_engine/rule_exceptions/components/flyout_components/add_to_lists_table/index.tsx
@@ -21,7 +21,7 @@ const ExceptionsAddToListsComponent: React.FC<ExceptionsAddToListsComponentProps
     error,
     isLoading,
     pagination,
-    sortedLists,
+    lists,
     listTableColumnsWithLinkSwitch,
     onTableChange,
     addToSelectedListDescription,
@@ -39,7 +39,7 @@ const ExceptionsAddToListsComponent: React.FC<ExceptionsAddToListsComponentProps
           tableCaption="Table of exception lists"
           data-test-subj="addExceptionToSharedListsTable"
           error={error}
-          items={sortedLists}
+          items={lists}
           loading={isLoading}
           message={
             isLoading ? (

diff --git a/...ule_exceptions/components/flyout_components/add_to_lists_table/use_add_to_lists_table.tsx b/...ule_exceptions/components/flyout_components/add_to_lists_table/use_add_to_lists_table.tsx
@@ -17,7 +17,6 @@ import type {
   EuiBasicTableColumn,
   HorizontalAlignment,
 } from '@elastic/eui';
-import { EuiLoadingContent } from '@elastic/eui';
 
 import type { ExceptionListSchema, ListArray } from '@kbn/securitysolution-io-ts-list-types';
 import { ExceptionListTypeEnum } from '@kbn/securitysolution-io-ts-list-types';
@@ -63,9 +62,6 @@ export const useAddToSharedListTable = ({
     initialPageSize: 5,
     showPerPageOptions: false,
   });
-  const [message, setMessage] = useState<JSX.Element | string | undefined>(
-    <EuiLoadingContent lines={4} data-test-subj="exceptionItemListsTableLoading" />
-  );
 
   const [error, setError] = useState<string | undefined>(undefined);
 
@@ -83,21 +79,21 @@ export const useAddToSharedListTable = ({
     }
   }, [listsToFetch]);
 
-  useEffect(() => {
-    getReferences();
-  }, [listsToFetch, getReferences]);
-
-  useEffect(() => {
+  const fillListsToDisplay = useCallback(async () => {
+    await getReferences();
     if (exceptionListReferences) {
       const lists: ExceptionListRuleReferencesSchema[] = [];
       for (const [_, value] of Object.entries(exceptionListReferences))
         if (value.type === ExceptionListTypeEnum.DETECTION) lists.push(value);
 
-      setMessage(undefined);
       setListsToDisplay(lists);
       setIsLoading(false);
     }
-  }, [exceptionListReferences, showAllSharedLists]);
+  }, [exceptionListReferences, getReferences]);
+
+  useEffect(() => {
+    fillListsToDisplay();
+  }, [listsToFetch, getReferences, fillListsToDisplay]);
 
   useEffect(() => {
     onListSelectionChange(
@@ -148,9 +144,8 @@ export const useAddToSharedListTable = ({
   return {
     error,
     isLoading,
-    message,
     pagination,
-    sortedLists: listsToDisplay,
+    lists: listsToDisplay,
     listTableColumnsWithLinkSwitch,
     addToSelectedListDescription: i18n.ADD_TO_LISTS_DESCRIPTION,
     onTableChange,