Use alternative flaky fix

elastic · Apr 2, 2020 · cca9076 · cca9076
1 parent 618b0f5
commit cca9076
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/test/functional/apps/discover/_field_visualize.ts b/test/functional/apps/discover/_field_visualize.ts
@@ -52,7 +52,6 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
 
     it('should visualize a field in area chart', async () => {
       await PageObjects.discover.findFieldByName('phpmemory');
-      await PageObjects.discover.clickFieldListItem('phpmemory');
       log.debug('visualize a phpmemory field');
       await PageObjects.discover.clickFieldListItemVisualize('phpmemory');
       await PageObjects.header.waitUntilLoadingHasFinished();
@@ -86,7 +85,6 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
     it('should preserve app filters in visualize', async () => {
       await filterBar.addFilter('bytes', 'is between', '3500', '4000');
       await PageObjects.discover.findFieldByName('geo.src');
-      await PageObjects.discover.clickFieldListItem('geo.src');
       log.debug('visualize a geo.src field with filter applied');
       await PageObjects.discover.clickFieldListItemVisualize('geo.src');
       await PageObjects.header.waitUntilLoadingHasFinished();
@@ -123,7 +121,6 @@ export default function({ getService, getPageObjects }: FtrProviderContext) {
       await queryBar.setQuery('machine.os : ios');
       await queryBar.submitQuery();
       await PageObjects.discover.findFieldByName('geo.dest');
-      await PageObjects.discover.clickFieldListItem('geo.dest');
       log.debug('visualize a geo.dest field with query applied');
       await PageObjects.discover.clickFieldListItemVisualize('geo.dest');
       await PageObjects.header.waitUntilLoadingHasFinished();

diff --git a/test/functional/page_objects/discover_page.ts b/test/functional/page_objects/discover_page.ts
@@ -244,10 +244,16 @@ export function DiscoverPageProvider({ getService, getPageObjects }: FtrProvider
       await testSubjects.click(`fieldToggle-${field}`);
     }
 
-    public async clickFieldListItemVisualize(field: string) {
-      return await retry.try(async () => {
-        await testSubjects.click(`fieldVisualize-${field}`);
-      });
+    public async clickFieldListItemVisualize(fieldName: string) {
+      const field = await testSubjects.find(`field-${fieldName}`);
+      const isActive = await field.elementHasClass('dscSidebarItem--active');
+
+      if (!isActive) {
+        // expand the field to show the "Visualize" button
+        await field.click();
+      }
+
+      await testSubjects.click(`fieldVisualize-${fieldName}`);
     }
 
     public async expectFieldListItemVisualize(field: string) {