fix type issues

elastic · Jan 18, 2023 · c9400ba · c9400ba
1 parent 1273c60
commit c9400ba
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/plugins/controls/public/options_list/embeddable/options_list_embeddable.tsx b/src/plugins/controls/public/options_list/embeddable/options_list_embeddable.tsx
@@ -273,7 +273,7 @@ export class OptionsListEmbeddable extends Embeddable<OptionsListEmbeddableInput
     return { dataView: this.dataView, field: this.field! };
   };
 
-  private runOptionsListQuery = async (clearCache: boolean = false) => {
+  private runOptionsListQuery = async () => {
     const {
       dispatch,
       getState,
@@ -312,9 +312,6 @@ export class OptionsListEmbeddable extends Embeddable<OptionsListEmbeddableInput
               mode: 'absolute' as 'absolute',
             }
           : globalTimeRange;
-      if (clearCache) {
-        this.optionsListService.clearOptionsListCache();
-      }
       const { suggestions, invalidSelections, totalCardinality, rejected } =
         await this.optionsListService.runOptionsListRequest(
           {
@@ -414,7 +411,8 @@ export class OptionsListEmbeddable extends Embeddable<OptionsListEmbeddableInput
   };
 
   reload = (clearCache: boolean = false) => {
-    this.runOptionsListQuery(clearCache);
+    if (clearCache) this.optionsListService.clearOptionsListCache();
+    this.runOptionsListQuery();
   };
 
   public destroy = () => {

diff --git a/src/plugins/controls/public/services/options_list/options_list.story.ts b/src/plugins/controls/public/services/options_list/options_list.story.ts
@@ -26,12 +26,15 @@ let optionsListRequestMethod = async (request: OptionsListRequest, abortSignal:
     )
   );
 
+const clearOptionsListCacheMock = () => {};
+
 export const replaceOptionsListMethod = (
   newMethod: (request: OptionsListRequest, abortSignal: AbortSignal) => Promise<OptionsListResponse>
 ) => (optionsListRequestMethod = newMethod);
 
 export const optionsListServiceFactory: OptionsListServiceFactory = () => {
   return {
     runOptionsListRequest: optionsListRequestMethod,
+    clearOptionsListCache: clearOptionsListCacheMock,
   };
 };