Skip to content

Commit

Permalink
RangeOption: Get rid of ts-ignore (#45902) (#46444)
Browse files Browse the repository at this point in the history
* Get rid of ts-ignore

* Update range.tsx

* Refactoring
  • Loading branch information
maryia-lapata committed Sep 24, 2019
1 parent 65217c0 commit c86e149
Showing 1 changed file with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import React, { useState } from 'react';
import { EuiFormRow, EuiRange } from '@elastic/eui';
import { EuiFormRow, EuiRange, EuiRangeProps } from '@elastic/eui';
import { i18n } from '@kbn/i18n';

interface RangeOptionProps<ParamName extends string> {
Expand Down Expand Up @@ -50,10 +50,9 @@ function RangeOption<ParamName extends string>({
values: { min, max },
});

const onChangeHandler = (
{ target: { valueAsNumber } }: React.ChangeEvent<HTMLInputElement>,
isValid: boolean
) => {
const onChangeHandler: EuiRangeProps['onChange'] = (event, isValid) => {
const { valueAsNumber } = event.target as HTMLInputElement; // since we don't show ticks on EuiRange, the target will definitely be HTMLInputElement type, so we can cast it directly.

setStateValue(valueAsNumber);
setIsValidState(isValid);

Expand All @@ -72,7 +71,6 @@ function RangeOption<ParamName extends string>({
showInput={showInput}
step={step}
value={stateValue}
// @ts-ignore
onChange={onChangeHandler}
/>
</EuiFormRow>
Expand Down

0 comments on commit c86e149

Please sign in to comment.