chore(NA): remove lodash 3 types from src and move test to lodash4

test/api_integration/apis/index_patterns/fields_for_wildcard_route/response.js

@@ -18,7 +18,7 @@
  */
 
 import expect from '@kbn/expect';
-import { sortBy } from 'lodash';
+import { sortBy } from 'lodash4';
 
 export default function ({ getService }) {
   const esArchiver = getService('esArchiver');

test/api_integration/apis/kql_telemetry/kql_telemetry.js

@@ -19,7 +19,7 @@
 
 import expect from '@kbn/expect';
 import Bluebird from 'bluebird';
-import { get } from 'lodash';
+import { get } from 'lodash4';
 
 export default function ({ getService }) {
   const supertest = getService('supertest');

test/api_integration/apis/saved_objects/bulk_update.js

@@ -18,7 +18,7 @@
  */
 
 import expect from '@kbn/expect';
-import _ from 'lodash';
+import _ from 'lodash4';
 
 export default function ({ getService }) {
   const supertest = getService('supertest');

test/api_integration/apis/saved_objects/migrations.js

@@ -21,7 +21,7 @@
  * Smokescreen tests for core migration logic
  */
 
-import _ from 'lodash';
+import _ from 'lodash4';
 import { assert } from 'chai';
 import {
   DocumentMigrator,
@@ -293,7 +293,7 @@ export default ({ getService }) => {
 
       // It only created the original and the dest
       assert.deepEqual(
-        _.pluck(
+        _.map(
           await callCluster('cat.indices', { index: '.migration-c*', format: 'json' }),
           'index'
         ).sort(),

test/api_integration/apis/telemetry/telemetry_local.js

@@ -18,7 +18,7 @@
  */
 
 import expect from '@kbn/expect';
-import _ from 'lodash';
+import _ from 'lodash4';
 
 /*
  * Create a single-level array with strings for all the paths to values in the

test/functional/apps/management/_import_objects.js

@@ -19,7 +19,7 @@
 
 import expect from '@kbn/expect';
 import path from 'path';
-import { indexBy } from 'lodash';
+import { keyBy } from 'lodash4';
 
 export default function ({ getService, getPageObjects }) {
   const kibanaServer = getService('kibanaServer');
@@ -50,15 +50,12 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.settings.clickImportDone();
 
         // get all the elements in the table, and index them by the 'title' visible text field
-        const elements = indexBy(
-          await PageObjects.settings.getSavedObjectElementsInTable(),
-          'title'
-        );
+        const elements = keyBy(await PageObjects.settings.getSavedObjectElementsInTable(), 'title');
         log.debug("check that 'Log Agents' is in table as a visualization");
         expect(elements['Log Agents'].objectType).to.eql('visualization');
 
         await elements['logstash-*'].relationshipsElement.click();
-        const flyout = indexBy(await PageObjects.settings.getRelationshipFlyout(), 'title');
+        const flyout = keyBy(await PageObjects.settings.getRelationshipFlyout(), 'title');
         log.debug(
           "check that 'Shared-Item Visualization AreaChart' shows 'logstash-*' as it's Parent"
         );
@@ -153,10 +150,7 @@ export default function ({ getService, getPageObjects }) {
       });
 
       it('should not import saved objects linked to saved searches when saved search index pattern does not exist', async function () {
-        const elements = indexBy(
-          await PageObjects.settings.getSavedObjectElementsInTable(),
-          'title'
-        );
+        const elements = keyBy(await PageObjects.settings.getSavedObjectElementsInTable(), 'title');
         await elements['logstash-*'].checkbox.click();
         await PageObjects.settings.clickSavedObjectsDelete();
 
@@ -188,10 +182,7 @@ export default function ({ getService, getPageObjects }) {
 
       it('should import saved objects with index patterns when index patterns does not exists', async () => {
         // First, we need to delete the index pattern
-        const elements = indexBy(
-          await PageObjects.settings.getSavedObjectElementsInTable(),
-          'title'
-        );
+        const elements = keyBy(await PageObjects.settings.getSavedObjectElementsInTable(), 'title');
         await elements['logstash-*'].checkbox.click();
         await PageObjects.settings.clickSavedObjectsDelete();
 
@@ -330,10 +321,7 @@ export default function ({ getService, getPageObjects }) {
         await PageObjects.settings.clickImportDone();
 
         // Second, we need to delete the index pattern
-        const elements = indexBy(
-          await PageObjects.settings.getSavedObjectElementsInTable(),
-          'title'
-        );
+        const elements = keyBy(await PageObjects.settings.getSavedObjectElementsInTable(), 'title');
         await elements['logstash-*'].checkbox.click();
         await PageObjects.settings.clickSavedObjectsDelete();
 
@@ -365,10 +353,7 @@ export default function ({ getService, getPageObjects }) {
 
       it('should import saved objects with index patterns when index patterns does not exists', async () => {
         // First, we need to delete the index pattern
-        const elements = indexBy(
-          await PageObjects.settings.getSavedObjectElementsInTable(),
-          'title'
-        );
+        const elements = keyBy(await PageObjects.settings.getSavedObjectElementsInTable(), 'title');
         await elements['logstash-*'].checkbox.click();
         await PageObjects.settings.clickSavedObjectsDelete();
 

test/functional/apps/visualize/_chart_types.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import _ from 'lodash';
+import _ from 'lodash4';
 import expect from '@kbn/expect';
 import { FtrProviderContext } from '../../ftr_provider_context';
 

test/functional/page_objects/common_page.ts

@@ -19,7 +19,7 @@
 
 import { delay } from 'bluebird';
 import expect from '@kbn/expect';
-import { get } from 'lodash';
+import { get } from 'lodash4';
 // @ts-ignore
 import fetch from 'node-fetch';
 import { FtrProviderContext } from '../ftr_provider_context';

test/functional/services/common/browser.ts

@@ -17,7 +17,7 @@
  * under the License.
  */
 
-import { cloneDeep } from 'lodash';
+import { cloneDeepWith } from 'lodash4';
 import { Key, Origin } from 'selenium-webdriver';
 // @ts-ignore internal modules are not typed
 import { LegacyActionSequence } from 'selenium-webdriver/lib/actions';
@@ -471,7 +471,7 @@ export async function BrowserProvider({ getService }: FtrProviderContext) {
     ): Promise<R> {
       return await driver.executeScript(
         fn,
-        ...cloneDeep<any>(args, (arg) => {
+        ...cloneDeepWith<any>(args, (arg) => {
           if (arg instanceof WebElementWrapper) {
             return arg._webElement;
           }
@@ -485,7 +485,7 @@ export async function BrowserProvider({ getService }: FtrProviderContext) {
     ): Promise<R> {
       return await driver.executeAsyncScript(
         fn,
-        ...cloneDeep<any>(args, (arg) => {
+        ...cloneDeepWith<any>(args, (arg) => {
           if (arg instanceof WebElementWrapper) {
             return arg._webElement;
           }

test/tsconfig.json

@@ -14,7 +14,6 @@
   "include": [
     "**/*.ts",
     "**/*.tsx",
-    "../typings/lodash.topath/*.ts",
     "../typings/elastic__node_crypto.d.ts",
     "typings/**/*"
   ],

test/visual_regression/services/visual_testing/visual_testing.ts

@@ -19,7 +19,6 @@
 
 import { postSnapshot } from '@percy/agent/dist/utils/sdk-utils';
 import { Test } from 'mocha';
-import _ from 'lodash';
 
 import testSubjSelector from '@kbn/test-subj-selector';