added comment and popover id

elastic · Jun 12, 2020 · bdd87fd · bdd87fd
1 parent e269a1a
commit bdd87fd
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/x-pack/plugins/security_solution/public/resolver/view/edge_line.tsx b/x-pack/plugins/security_solution/public/resolver/view/edge_line.tsx
@@ -117,6 +117,9 @@ const EdgeLineComponent = React.memo(
 
     let elapsedTimeLeftPosPct = 50;
 
+    /**
+     * Calculates a fractional offset from 0 -> 5% as magFactorX decreases from 1 to a min of .5
+     */
     if (magFactorX < 1) {
       const fractionalOffset = (1 / magFactorX) * ((1 - magFactorX) * 10);
       elapsedTimeLeftPosPct += fractionalOffset;

diff --git a/x-pack/plugins/security_solution/public/resolver/view/submenu.tsx b/x-pack/plugins/security_solution/public/resolver/view/submenu.tsx
@@ -6,7 +6,7 @@
 
 import { i18n } from '@kbn/i18n';
 import React, { ReactNode, useState, useMemo, useCallback } from 'react';
-import { EuiSelectable, EuiButton, EuiPopover, ButtonColor } from '@elastic/eui';
+import { EuiSelectable, EuiButton, EuiPopover, ButtonColor, htmlIdGenerator } from '@elastic/eui';
 import styled from 'styled-components';
 
 /**
@@ -35,7 +35,7 @@ export const subMenuAssets = {
     }),
   },
 };
-
+const idGenerator = htmlIdGenerator();
 interface ResolverSubmenuOption {
   optionTitle: string;
   action: () => unknown;
@@ -137,7 +137,8 @@ const NodeSubMenuComponents = React.memo(
       [menuAction]
     );
 
-    const closePopover = () => setMenuOpen(false);
+    const closePopover = useCallback(() => setMenuOpen(false), []);
+    const popoverId = idGenerator('submenu-popover');
 
     const isMenuLoading = optionsWithActions === 'waitingForRelatedEventData';
 
@@ -182,7 +183,7 @@ const NodeSubMenuComponents = React.memo(
     return (
       <div className={className + (menuIsOpen ? ' is-open' : '')}>
         <EuiPopover
-          id="popover"
+          id={popoverId}
           panelPaddingSize="none"
           button={submenuPopoverButton}
           isOpen={menuIsOpen}