-
Notifications
You must be signed in to change notification settings - Fork 8.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ML] Data Frame Analytics: Fix confusion matrix data grid width. (#65818
) (#66355) - Fixes an issue where hiding all columns for the confusion matrix would hide the menu item to enable columns again. - Replaces resizeHandler based workaround for EuiDataGrid within flex layouts with a CSS based workaround. - Moves inline styles to SCSS file and imports that file directly. - Fixes IE11 layout issues.
- Loading branch information
Showing
4 changed files
with
151 additions
and
165 deletions.
There are no files selected for viewing
1 change: 0 additions & 1 deletion
1
x-pack/plugins/ml/public/application/data_frame_analytics/_index.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,4 @@ | ||
@import 'pages/analytics_exploration/components/regression_exploration/index'; | ||
@import 'pages/analytics_exploration/components/classification_exploration/index'; | ||
@import 'pages/analytics_management/components/analytics_list/index'; | ||
@import 'pages/analytics_management/components/create_analytics_form/index'; | ||
@import 'pages/analytics_management/components/create_analytics_flyout/index'; |
35 changes: 33 additions & 2 deletions
35
...lytics_exploration/components/classification_exploration/_classification_exploration.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,35 @@ | ||
.euiFormRow.mlDataFrameAnalyticsClassification__actualLabel { | ||
padding-top: $euiSize * 4; | ||
/* | ||
Workaround for EuiDataGrid within a Flex Layout, | ||
this tricks browsers treating the width as a px value instead of % | ||
*/ | ||
.mlDataFrameAnalyticsClassification { | ||
width: 100%; | ||
} | ||
|
||
.mlDataFrameAnalyticsClassification__confusionMatrix { | ||
padding: 0 5%; | ||
} | ||
|
||
/* | ||
The following two classes are a workaround to avoid having EuiDataGrid in a flex layout | ||
and just uses a legacy approach for a two column layout so we don't break IE11. | ||
*/ | ||
.mlDataFrameAnalyticsClassification__confusionMatrix:after { | ||
content: ""; | ||
display: table; | ||
clear: both; | ||
} | ||
|
||
.mlDataFrameAnalyticsClassification__actualLabel { | ||
float: left; | ||
width: 80px; | ||
padding-top: $euiSize * 4 + $euiSizeXS; | ||
} | ||
|
||
/* | ||
Gives EuiDataGrid a min-width of 480px, otherwise the columns options will disappear if you hide all columns. | ||
*/ | ||
.mlDataFrameAnalyticsClassification__dataGridMinWidth { | ||
min-width: 480px; | ||
width: 100%; | ||
} |
1 change: 0 additions & 1 deletion
1
...e_analytics/pages/analytics_exploration/components/classification_exploration/_index.scss
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters