address review feedback

elastic · Feb 24, 2021 · b948291 · b948291
1 parent eac1feb
commit b948291
Showing 1 changed file with 18 additions and 16 deletions.
diff --git a/x-pack/plugins/upgrade_assistant/server/lib/reindexing/index_settings.test.ts b/x-pack/plugins/upgrade_assistant/server/lib/reindexing/index_settings.test.ts
@@ -181,22 +181,24 @@ describe('getReindexWarnings', () => {
   });
 
   if (mockKibanaSemverVersion.major === 7) {
-    it('returns customTypeName for non-_doc mapping types', () => {
-      expect(
-        getReindexWarnings({
-          settings: {},
-          mappings: { doc: {} },
-        })
-      ).toEqual([ReindexWarning.customTypeName]);
-    });
-
-    it('does not return customTypeName for _doc mapping types', () => {
-      expect(
-        getReindexWarnings({
-          settings: {},
-          mappings: { _doc: {} },
-        })
-      ).toEqual([]);
+    describe('customTypeName warning', () => {
+      it('returns customTypeName for non-_doc mapping types', () => {
+        expect(
+          getReindexWarnings({
+            settings: {},
+            mappings: { doc: {} },
+          })
+        ).toEqual([ReindexWarning.customTypeName]);
+      });
+
+      it('does not return customTypeName for _doc mapping types', () => {
+        expect(
+          getReindexWarnings({
+            settings: {},
+            mappings: { _doc: {} },
+          })
+        ).toEqual([]);
+      });
     });
   }
 });