Skip to content

Commit

Permalink
Addressing feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
clintandrewhall committed Oct 13, 2021
1 parent 3f040b7 commit b3bc576
Showing 1 changed file with 24 additions and 46 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,17 +7,7 @@

import React from 'react';
import styled from 'styled-components';
import {
EuiPanel,
EuiFlexGroup,
EuiFlexItem,
EuiText,
EuiTitle,
EuiBadge,
EuiToolTip,
EuiSpacer,
EuiLink,
} from '@elastic/eui';
import { EuiCard, EuiFlexItem, EuiBadge, EuiToolTip, EuiSpacer } from '@elastic/eui';

import { CardIcon } from '../../../../../components/package_icon';
import type { IntegrationCardItem } from '../../../../../../common/types/models/epm';
Expand All @@ -26,13 +16,10 @@ import { RELEASE_BADGE_DESCRIPTION, RELEASE_BADGE_LABEL } from './release_badge'

export type PackageCardProps = IntegrationCardItem;

const Link = styled(EuiLink)`
&.euiLink {
color: inherit;
}
&.euiLink:hover {
text-decoration: none;
}
// adding the `href` causes EuiCard to use a `a` instead of a `button`
// `a` tags use `euiLinkColor` which results in blueish Badge text
const Card = styled(EuiCard)`
color: inherit;
`;

export function PackageCard({
Expand Down Expand Up @@ -61,33 +48,24 @@ export function PackageCard({
}

return (
<Link href={url}>
<EuiPanel paddingSize="m">
<EuiFlexGroup gutterSize="m" responsive={false}>
<EuiFlexItem grow={false}>
<CardIcon
icons={icons}
packageName={name}
integrationName={integration}
version={version}
size="xl"
/>
</EuiFlexItem>
<EuiFlexItem>
<EuiFlexGroup direction="column" gutterSize="s" responsive={false}>
<EuiFlexItem>
<EuiTitle size="xs">
<h3>{title}</h3>
</EuiTitle>
</EuiFlexItem>
<EuiFlexItem>
<EuiText size="s">{description}</EuiText>
</EuiFlexItem>
{releaseBadge}
</EuiFlexGroup>
</EuiFlexItem>
</EuiFlexGroup>
</EuiPanel>
</Link>
<Card
layout="horizontal"
title={title || ''}
titleSize="xs"
description={description}
icon={
<CardIcon
icons={icons}
packageName={name}
integrationName={integration}
version={version}
size="xl"
/>
}
href={url}
target={url.startsWith('http') || url.startsWith('https') ? '_blank' : undefined}
>
{releaseBadge}
</Card>
);
}

0 comments on commit b3bc576

Please sign in to comment.