Allow getAsSavedObjectBody to return non-scripted fields when allowNo…

…Index is true

(cherry picked from commit 69b93da)

src/plugins/data/common/index_patterns/index_patterns/index_pattern.test.ts

@@ -17,7 +17,7 @@ import { stubbedSavedObjectIndexPattern } from './fixtures/stubbed_saved_object_
 import { IndexPatternField } from '../fields';
 
 import { fieldFormatsMock } from '../../field_formats/mocks';
-import { FieldFormat } from '../..';
+import { FieldFormat, IndexPatternSpec } from '../..';
 import { RuntimeField } from '../types';
 
 class MockFieldFormatter {}
@@ -42,7 +42,7 @@ const runtimeField = {
 fieldFormatsMock.getInstance = jest.fn().mockImplementation(() => new MockFieldFormatter()) as any;
 
 // helper function to create index patterns
-function create(id: string) {
+function create(id: string, spec?: Partial<IndexPatternSpec>) {
   const {
     type,
     version,
@@ -58,6 +58,7 @@ function create(id: string) {
       fields: { ...fields, runtime_field: runtimeField },
       title,
       runtimeFieldMap,
+      ...(spec || {}),
     },
     fieldFormats: fieldFormatsMock,
     shortDotsEnable: false,
@@ -314,4 +315,15 @@ describe('IndexPattern', () => {
       expect(restoredPattern.fields.length).toEqual(indexPattern.fields.length);
     });
   });
+
+  describe('getAsSavedObjectBody', () => {
+    test('should match snapshot', () => {
+      expect(indexPattern.getAsSavedObjectBody()).toMatchSnapshot();
+    });
+
+    test('allowNoIndex perserves all fields', () => {
+      const allowNoIndexIndexPattern = create('test-no-index-pattern', { allowNoIndex: true });
+      expect(allowNoIndexIndexPattern.getAsSavedObjectBody()).toMatchSnapshot();
+    });
+  });
 });

src/plugins/data/common/index_patterns/index_patterns/index_pattern.ts

@@ -322,7 +322,9 @@ export class IndexPattern implements IIndexPattern {
       intervalName: this.intervalName,
       sourceFilters: this.sourceFilters ? JSON.stringify(this.sourceFilters) : undefined,
       fields: this.fields
-        ? JSON.stringify(this.fields.filter((field) => field.scripted))
+        ? JSON.stringify(
+            this.allowNoIndex ? this.fields : this.fields.filter((field) => field.scripted)
+          )
         : undefined,
       fieldFormatMap,
       type: this.type,