review III

elastic · Apr 2, 2022 · ab671cf · ab671cf
1 parent f71b13c
commit ab671cf
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 9 deletions.
diff --git a/x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.test.ts b/x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.test.ts
@@ -248,8 +248,6 @@ describe('formatExecutionLogResult', () => {
     expect(formatExecutionLogResult({ aggregations: undefined })).toEqual({
       total: 0,
       data: [],
-      errors: [],
-      totalErrors: 0,
     });
   });
   test('should return empty results if aggregations.excludeExecuteStart are undefined', () => {
@@ -260,8 +258,6 @@ describe('formatExecutionLogResult', () => {
     ).toEqual({
       total: 0,
       data: [],
-      errors: [],
-      totalErrors: 0,
     });
   });
   test('should format results correctly', () => {

diff --git a/x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts b/x-pack/plugins/alerting/server/lib/get_execution_log_aggregation.ts
@@ -34,9 +34,7 @@ const Millis2Nanos = 1000 * 1000;
 
 export const EMPTY_EXECUTION_LOG_RESULT = {
   total: 0,
-  totalErrors: 0,
   data: [],
-  errors: [],
 };
 
 interface IAlertCounts extends estypes.AggregationsMultiBucketAggregateBase {
@@ -299,7 +297,7 @@ function formatExecutionLogAggBucket(bucket: IExecutionUuidAggBucket): IExecutio
 
 export function formatExecutionLogResult(
   results: AggregateEventsBySavedObjectResult
-): Pick<IExecutionLogResult, 'total' | 'data'> {
+): IExecutionLogResult {
   const { aggregations } = results;
 
   if (!aggregations || !aggregations.excludeExecuteStart) {

diff --git a/.../plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule.tsx b/.../plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule.tsx
@@ -12,7 +12,6 @@ import {
   EuiSpacer,
   EuiFlexGroup,
   EuiFlexItem,
-  EuiHorizontalRule,
   EuiPanel,
   EuiStat,
   EuiIconTip,

diff --git a/...riggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.tsx b/...riggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.tsx
@@ -227,7 +227,6 @@ export const RuleErrorLog = (props: RuleErrorLogProps) => {
         data-test-subj="RuleErrorLog"
         loading={isLoading}
         items={logList ?? []}
-        itemId="id"
         columns={columns}
         sorting={{ sort }}
         pagination={pagination}