Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
* Do not collect code coverage on test_helpers Note: some test helpers are no longer being used but might be some day - e.g., shallowWithIntl will be used on the beta badge * Fix uncovered type line - since we're not iterating over productNames, no need for it to be an array - it can be written more clearly in string union format * Fix branch coverage on index.tsx - Since KibanaLogic is setting `|| {}` fallbacks in any case, I've opted to remove them in this file and let fallbacks be handled there - Fixed typing to make it clear plugins can be undefined (i.e., disabled/optional, etc) in props + reorganize w/ comments - KibanaValues requires an Omit to override props types * Crawler DomainsTable test coverage/improvements - Fix test failing locally due to timezones by increasing the timezone offset - Cover missing branch line by adding a domain with no `lastCrawl` - Remove unnecessary extra beforeEach with dupe re-shallow/mounts - move getTable helper to its most relevant block (it's not being used in the generic column content checks, only in the actions column suite) Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx
- Loading branch information