Review feedback

elastic · Jul 28, 2020 · a86551b · a86551b
1 parent 72eb667
commit a86551b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/x-pack/plugins/apm/public/components/app/TraceOverview/TraceList.tsx b/x-pack/plugins/apm/public/components/app/TraceOverview/TraceList.tsx
@@ -37,10 +37,7 @@ const traceListColumns: Array<ITableColumn<TransactionGroup>> = [
     width: '40%',
     sortable: true,
     render: (_: string, { sample }: TransactionGroup) => (
-      <EuiToolTip
-        id="trace-transaction-link-tooltip"
-        content={sample.transaction.name}
-      >
+      <EuiToolTip content={sample.transaction.name}>
         <StyledTransactionLink
           serviceName={sample.service.name}
           transactionId={sample.transaction.id}

diff --git a/x-pack/plugins/apm/server/lib/metrics/fetch_and_transform_metrics.ts b/x-pack/plugins/apm/server/lib/metrics/fetch_and_transform_metrics.ts
@@ -25,7 +25,7 @@ type MetricsAggregationMap = Unionize<{
   avg: AggregationOptionsByType['avg'];
 }>;
 
-type Aggs = Record<string, MetricsAggregationMap>;
+type MetricAggs = Record<string, MetricsAggregationMap>;
 
 export type GenericMetricsRequest = Overwrite<
   ESSearchRequest,
@@ -34,9 +34,9 @@ export type GenericMetricsRequest = Overwrite<
       aggs: {
         timeseriesData: {
           date_histogram: AggregationOptionsByType['date_histogram'];
-          aggs: Record<string, MetricsAggregationMap>;
+          aggs: MetricAggs;
         };
-      } & Record<string, MetricsAggregationMap>;
+      } & MetricAggs;
     };
   }
 >;
@@ -50,7 +50,7 @@ interface Filter {
   };
 }
 
-export async function fetchAndTransformMetrics<T extends Aggs>({
+export async function fetchAndTransformMetrics<T extends MetricAggs>({
   setup,
   serviceName,
   serviceNodeName,