wip

elastic · Aug 24, 2023 · a558c40 · a558c40
1 parent f6e4023
commit a558c40
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/packages/kbn-optimizer/limits.yml b/packages/kbn-optimizer/limits.yml
@@ -96,6 +96,7 @@ pageLoadAssetSize:
   monitoring: 80000
   navigation: 37269
   newsfeed: 42228
+  noDataPage: 5000
   observability: 115443
   observabilityAIAssistant: 25000
   observabilityOnboarding: 19573

diff --git a/packages/shared-ux/page/analytics_no_data/impl/src/services.tsx b/packages/shared-ux/page/analytics_no_data/impl/src/services.tsx
@@ -49,7 +49,7 @@ export const AnalyticsNoDataPageKibanaProvider: FC<AnalyticsNoDataPageKibanaDepe
       hasCustomBranding$: dependencies.coreStart.customBranding.hasCustomBranding$,
     },
     prependBasePath: dependencies.coreStart.http.basePath.prepend,
-    pageFlavor: dependencies.noDataPage.getAnalyticsNoDataPageFlavor(),
+    pageFlavor: dependencies.noDataPage?.getAnalyticsNoDataPageFlavor() ?? 'kibana',
   };
   return (
     <Context.Provider {...{ value }}>

diff --git a/packages/shared-ux/page/analytics_no_data/types/index.d.ts b/packages/shared-ux/page/analytics_no_data/types/index.d.ts
@@ -46,7 +46,7 @@ export interface KibanaDependencies {
       };
     };
   };
-  noDataPage: {
+  noDataPage?: {
     getAnalyticsNoDataPageFlavor: () => AnalyticsNoDataPageFlavor;
   };
 }

diff --git a/src/plugins/visualizations/public/visualize_app/app.tsx b/src/plugins/visualizations/public/visualize_app/app.tsx
@@ -50,6 +50,9 @@ const NoDataComponent = ({
     coreStart: core,
     dataViews,
     dataViewEditor,
+    noDataPage: {
+      getAnalyticsNoDataPageFlavor: () => 'kibana' as const,
+    },
   };
   return (
     <AnalyticsNoDataPageKibanaProvider {...analyticsServices}>
-Original file line number
+Diff line change
@@ Expand Up / @@ -46,7 +46,7 @@ export interface KibanaDependencies { @@
           };
         };
       };
-      noDataPage: {
+      noDataPage?: {
         getAnalyticsNoDataPageFlavor: () => AnalyticsNoDataPageFlavor;
       };
     }
@@ Expand Down @@