Skip to content

Commit

Permalink
Merge branch 'master' into alerting/disable-actions-plugin-ESO-tmp-key
Browse files Browse the repository at this point in the history
  • Loading branch information
elasticmachine authored Feb 12, 2020
2 parents 1cf1cac + 5e687b1 commit a23511b
Show file tree
Hide file tree
Showing 480 changed files with 12,368 additions and 2,957 deletions.
65 changes: 65 additions & 0 deletions docs/accessibility.asciidoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
[chapter]
[[accessibility]]
= Accessibility Statement for Kibana
++++
<titleabbrev>Accessibility</titleabbrev>
++++

Elastic is committed to ensuring digital accessibility for people with disabilities. We are continually improving the user experience, and strive toward ensuring our tools are usable by everyone.

[float]
[[accessibility-measures]]
== Measures to support accessibility
Elastic takes the following measures to ensure accessibility of Kibana:

* Maintains and incorporates an https://elastic.github.io/eui/[accessible component library].
* Provides continual accessibility training for our staff.
* Employs a third-party audit.

[float]
[[accessibility-conformance-status]]
== Conformance status
Kibana aims to meet https://www.w3.org/WAI/WCAG21/quickref/?currentsidebar=%23col_customize&levels=aaa&technologies=server%2Csmil%2Cflash%2Csl[WCAG 2.1 level AA] compliance. Currently, we can only claim to partially conform, meaning we do not fully meet all of the success criteria. However, we do try to take a broader view of accessibility, and go above and beyond the legal and regulatory standards to provide a good experience for all of our users.

[float]
[[accessibility-feedback]]
== Feedback
We welcome your feedback on the accessibility of Kibana. Please let us know if you encounter accessibility barriers on Kibana by either emailing us at accessibility@elastic.co or opening https://github.com/elastic/kibana/issues/new?labels=Project%3AAccessibility&template=Accessibility.md&title=%28Accessibility%29[an issue on GitHub].

[float]
[[accessibility-specs]]
== Technical specifications
Accessibility of Kibana relies on the following technologies to work with your web browser and any assistive technologies or plugins installed on your computer:

* HTML
* CSS
* JavaScript
* WAI-ARIA

[float]
[[accessibility-limitations-and-alternatives]]
== Limitations and alternatives
Despite our best efforts to ensure accessibility of Kibana, there are some limitations. Please https://github.com/elastic/kibana/issues/new?labels=Project%3AAccessibility&template=Accessibility.md&title=%28Accessibility%29[open an issue on GitHub] if you observe an issue not in this list.

Known limitations are in the following areas:

* *Charts*: We have a clear plan for the first steps of making charts accessible. We’ve opened this https://github.com/elastic/elastic-charts/issues/300[Charts accessibility ticket on GitHub] for tracking our progress.
* *Maps*: Maps might pose difficulties to users with vision disabilities. We welcome your input on making our maps accessible. Go to the https://github.com/elastic/kibana/issues/57271[Maps accessibility ticket on GitHub] to join the discussion and view our plans.
* *Tables*: Although generally accessible and marked-up as standard HTML tables with column headers, tables rarely make use of row headers and have poor captions. You will see incremental improvements as various applications adopt a new accessible component.
* *Color contrast*: Modern Kibana interfaces generally do not have color contrast issues. However, older code might fall below the recommended contrast levels. As we continue to update our code, this issue will phase out naturally.

To see individual tickets, view our https://github.com/elastic/kibana/issues?q=is%3Aissue+is%3Aopen+sort%3Aupdated-desc+label%3AProject%3AAccessibility[GitHub issues with label "`Project:Accessibility`"].

[float]
[[accessibility-approach]]
== Assessment approach
Elastic assesses the accessibility of Kibana with the following approaches:

* *Self-evaluation*: Our employees are familiar with accessibility standards and review new designs and implemented features to confirm that they are accessible.
* *External evaluation*: We engage external contractors to help us conduct an independent assessment and generate a formal VPAT. Please email accessibility@elastic.co if you’d like a copy.
* *Automated evaluation*: We are starting to run https://www.deque.com/axe/[axe] on every page. See our current progress in the https://github.com/elastic/kibana/issues/51456[automated testing GitHub issue].

Manual testing largely focuses on screen reader support and is done on:

* VoiceOver on MacOS with Safari, Chrome and Edge
* NVDA on Windows with Chrome and Firefox
2 changes: 2 additions & 0 deletions docs/index.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ include::{asciidoc-dir}/../../shared/attributes.asciidoc[]

include::user/index.asciidoc[]

include::accessibility.asciidoc[]

include::limitations.asciidoc[]

include::release-notes/highlights.asciidoc[]
Expand Down
2 changes: 1 addition & 1 deletion packages/kbn-pm/dist/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -108562,7 +108562,7 @@ __webpack_require__.r(__webpack_exports__);
* to Kibana itself.
*/

const isKibanaDep = depVersion => depVersion.includes('../../kibana/');
const isKibanaDep = depVersion => depVersion.includes('../../packages/');
/**
* This prepares the dependencies for an _external_ project.
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@
"name": "quux",
"version": "1.0.0",
"dependencies": {
"@kbn/foo": "link:../../kibana/packages/foo"
"@kbn/foo": "link:../../packages/foo"
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import { Project } from '../utils/project';
* to the Kibana root directory or `../kibana-extra/{plugin}` relative
* to Kibana itself.
*/
const isKibanaDep = (depVersion: string) => depVersion.includes('../../kibana/');
const isKibanaDep = (depVersion: string) => depVersion.includes('../../packages/');

/**
* This prepares the dependencies for an _external_ project.
Expand Down
24 changes: 12 additions & 12 deletions src/core/public/application/application_service.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ let service: ApplicationService;

describe('#setup()', () => {
beforeEach(() => {
const http = httpServiceMock.createSetupContract({ basePath: '/test' });
const http = httpServiceMock.createSetupContract({ basePath: '/base-path' });
setupDeps = {
http,
context: contextServiceMock.createSetupContract(),
Expand Down Expand Up @@ -167,7 +167,7 @@ describe('#setup()', () => {
const { register } = service.setup(setupDeps);

expect(() =>
register(Symbol(), createApp({ id: 'app2', appRoute: '/test/app2' }))
register(Symbol(), createApp({ id: 'app2', appRoute: '/base-path/app2' }))
).toThrowErrorMatchingInlineSnapshot(
`"Cannot register an application route that includes HTTP base path"`
);
Expand Down Expand Up @@ -430,7 +430,7 @@ describe('#start()', () => {
beforeEach(() => {
MockHistory.push.mockReset();

const http = httpServiceMock.createSetupContract({ basePath: '/test' });
const http = httpServiceMock.createSetupContract({ basePath: '/base-path' });
setupDeps = {
http,
context: contextServiceMock.createSetupContract(),
Expand Down Expand Up @@ -561,7 +561,7 @@ describe('#start()', () => {

const { getUrlForApp } = await service.start(startDeps);

expect(getUrlForApp('app1')).toBe('/app/app1');
expect(getUrlForApp('app1')).toBe('/base-path/app/app1');
});

it('creates URL for registered appId', async () => {
Expand All @@ -573,20 +573,20 @@ describe('#start()', () => {

const { getUrlForApp } = await service.start(startDeps);

expect(getUrlForApp('app1')).toBe('/app/app1');
expect(getUrlForApp('legacyApp1')).toBe('/app/legacyApp1');
expect(getUrlForApp('app2')).toBe('/custom/path');
expect(getUrlForApp('app1')).toBe('/base-path/app/app1');
expect(getUrlForApp('legacyApp1')).toBe('/base-path/app/legacyApp1');
expect(getUrlForApp('app2')).toBe('/base-path/custom/path');
});

it('creates URLs with path parameter', async () => {
service.setup(setupDeps);

const { getUrlForApp } = await service.start(startDeps);

expect(getUrlForApp('app1', { path: 'deep/link' })).toBe('/app/app1/deep/link');
expect(getUrlForApp('app1', { path: '/deep//link/' })).toBe('/app/app1/deep/link');
expect(getUrlForApp('app1', { path: '//deep/link//' })).toBe('/app/app1/deep/link');
expect(getUrlForApp('app1', { path: 'deep/link///' })).toBe('/app/app1/deep/link');
expect(getUrlForApp('app1', { path: 'deep/link' })).toBe('/base-path/app/app1/deep/link');
expect(getUrlForApp('app1', { path: '/deep//link/' })).toBe('/base-path/app/app1/deep/link');
expect(getUrlForApp('app1', { path: '//deep/link//' })).toBe('/base-path/app/app1/deep/link');
expect(getUrlForApp('app1', { path: 'deep/link///' })).toBe('/base-path/app/app1/deep/link');
});
});

Expand Down Expand Up @@ -659,7 +659,7 @@ describe('#start()', () => {
const { navigateToApp } = await service.start(startDeps);

await navigateToApp('myTestApp');
expect(setupDeps.redirectTo).toHaveBeenCalledWith('/test/app/myTestApp');
expect(setupDeps.redirectTo).toHaveBeenCalledWith('/base-path/app/myTestApp');
});

it('updates currentApp$ after mounting', async () => {
Expand Down
2 changes: 1 addition & 1 deletion src/core/public/application/application_service.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -273,7 +273,7 @@ export class ApplicationService {
),
registerMountContext: this.mountContext.registerContext,
getUrlForApp: (appId, { path }: { path?: string } = {}) =>
getAppUrl(availableMounters, appId, path),
http.basePath.prepend(getAppUrl(availableMounters, appId, path)),
navigateToApp: async (appId, { path, state }: { path?: string; state?: any } = {}) => {
if (await this.shouldNavigate(overlays)) {
this.appLeaveHandlers.delete(this.currentAppId$.value!);
Expand Down
22 changes: 11 additions & 11 deletions src/core/server/logging/__snapshots__/logging_service.test.ts.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit a23511b

Please sign in to comment.