should not throw error when fitting on empty data (#11620) (#11710)

elastic · May 11, 2017 · 9fef931 · 9fef931
1 parent 29ceef6
commit 9fef931
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/src/ui/public/vis_maps/__tests__/geohash_layer.js b/src/ui/public/vis_maps/__tests__/geohash_layer.js
@@ -483,6 +483,20 @@ describe('kibana_map tests', function () {
     });
 
 
+    it('should not throw when fitting on empty-data layer', function () {
+
+      const geohashLayer = new GeohashLayer({
+        type: 'FeatureCollection',
+        features: []
+      }, { 'mapType': 'Scaled Circle Markers' }, kibanaMap.getZoomLevel(), kibanaMap);
+      kibanaMap.addLayer(geohashLayer);
+
+      expect(() => {
+        kibanaMap.fitToData();
+      }).to.not.throwException();
+    });
+
+
   });
 
 });

diff --git a/src/ui/public/vis_maps/kibana_map.js b/src/ui/public/vis_maps/kibana_map.js
@@ -473,7 +473,7 @@ class KibanaMap extends EventEmitter {
       }
     });
 
-    if (bounds) {
+    if (bounds && bounds.isValid()) {
       this._leafletMap.fitBounds(bounds);
     }
   }