forget to close channel

elastic · Nov 22, 2021 · 9865819 · 9865819
1 parent 392af2f
commit 9865819
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/x-pack/plugins/security/public/nav_control/nav_control_service.tsx b/x-pack/plugins/security/public/nav_control/nav_control_service.tsx
@@ -114,6 +114,7 @@ export class SecurityNavControlService {
     }
     this.navControlRegistered = false;
     this.stop$.next();
+    this.channel?.close();
   }
 
   private registerSecurityNavControl(
@@ -176,6 +177,7 @@ export class SecurityNavControlService {
       setTimeout(async () => {
         if (!elector.isLeader) {
           // Let's kill the non leader since we do not need to do telemetry if you are not a leader
+          // but we are keeping the leader alive to tell the other one that they won't be leader
           await elector.die();
         }
       }, 5000);

diff --git a/x-pack/plugins/security/server/routes/telemetry/authentication_type.ts b/x-pack/plugins/security/server/routes/telemetry/authentication_type.ts
@@ -29,7 +29,7 @@ export function defineTelemetryOnAuthTypeRoutes({ router, usageCounter }: RouteD
 
         if (!authType || (authType && authType === '')) {
           return response.badRequest({
-            body: { message: `Authentication type attributes can not be empty` },
+            body: { message: `Authentication type attribute can not be empty` },
           });
         }