remove unnecessary logic

elastic · Nov 3, 2020 · 910b2be · 910b2be
1 parent 9f5d531
commit 910b2be
Showing 1 changed file with 4 additions and 9 deletions.
diff --git a/src/plugins/expressions/common/expression_functions/specs/moving_average.ts b/src/plugins/expressions/common/expression_functions/specs/moving_average.ts
@@ -124,23 +124,18 @@ export const movingAverage: ExpressionFunctionMovingAverage = {
       return input;
     }
 
-    const lastNValuesByBucket: Partial<Record<string, Array<number | undefined>>> = {};
+    const lastNValuesByBucket: Partial<Record<string, number[]>> = {};
     return {
       ...input,
       columns: resultColumns,
       rows: input.rows.map((row) => {
         const newRow = { ...row };
-
         const bucketIdentifier = getBucketIdentifier(row, by);
         const lastNValues = lastNValuesByBucket[bucketIdentifier];
         const currentValue = newRow[inputColumnId];
-        const sanitizedLastNValues = lastNValues?.filter((v) => v != null) as number[];
-        if (sanitizedLastNValues != null && sanitizedLastNValues.length && currentValue != null) {
-          const sanitizedSum = sanitizedLastNValues.reduce(
-            (acc: number, current: number) => acc + current,
-            0
-          );
-          newRow[outputColumnId] = sanitizedSum / sanitizedLastNValues.length;
+        if (lastNValues != null && lastNValues.length && currentValue != null) {
+          const sum = lastNValues.reduce((acc, current) => acc + current, 0);
+          newRow[outputColumnId] = sum / lastNValues.length;
         } else {
           newRow[outputColumnId] = undefined;
         }