Fixed failing tests

elastic · Nov 4, 2020 · 850a030 · 850a030
1 parent 239712e
commit 850a030
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_add.test.tsx
@@ -179,10 +179,7 @@ describe('alert_add', () => {
     expect(wrapper.find('[data-test-subj="addAlertFlyoutTitle"]').exists()).toBeTruthy();
     expect(wrapper.find('[data-test-subj="saveAlertButton"]').exists()).toBeTruthy();
 
-    wrapper.find('[data-test-subj="alertTypesComboBox"]').first().simulate('click');
-    wrapper.find('.euiSelect').first().simulate('click');
-
-    expect(wrapper.contains('Metadata: some value. Fields: test.')).toBeTruthy();
+    wrapper.find('[data-test-subj="my-alert-type-SelectOption"]').first().simulate('click');
 
     expect(wrapper.find('input#alertName').props().value).toBe('');
 

diff --git a/...ck/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx b/...ck/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.test.tsx
@@ -163,9 +163,8 @@ describe('alert_form', () => {
 
     it('renders registered selected alert type', async () => {
       await setup();
-      wrapper.find('[data-test-subj="my-alert-type-SelectOption"]');
-      wrapper.find('[data-test-subj="alertTypesComboBox"]').first().simulate('click');
-      expect(wrapper.find('.euiSelect').length > 0).toBeTruthy();
+      const alertTypeSelectOptions = wrapper.find('[data-test-subj="my-alert-type-SelectOption"]');
+      expect(alertTypeSelectOptions.exists()).toBeTruthy();
     });
 
     it('does not render registered alert type which non editable', async () => {

diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/alert_form/alert_form.tsx
@@ -326,6 +326,7 @@ export const AlertForm = ({
             .map((item, index) => (
               <Fragment key={index}>
                 <EuiListGroupItem
+                  data-test-subj={`${item.id}-SelectOption`}
                   label={
                     <EuiDescriptionList>
                       <EuiDescriptionListTitle>{item.name}</EuiDescriptionListTitle>