Make usageCollection an optional dependency

If it's not enabled, we simply use a noop for our tracker call.
elastic · Apr 29, 2020 · 809382a · 809382a
1 parent 687d301
commit 809382a
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/x-pack/plugins/siem/kibana.json b/x-pack/plugins/siem/kibana.json
@@ -14,10 +14,16 @@
     "licensing",
     "maps",
     "triggers_actions_ui",
-    "uiActions",
+    "uiActions"
+  ],
+  "optionalPlugins": [
+    "encryptedSavedObjects",
+    "ml",
+    "newsfeed",
+    "security",
+    "spaces",
     "usageCollection"
   ],
-  "optionalPlugins": ["encryptedSavedObjects", "ml", "newsfeed", "security", "spaces"],
   "server": true,
   "ui": true
 }
diff --git a/x-pack/plugins/siem/public/lib/telemetry/index.ts b/x-pack/plugins/siem/public/lib/telemetry/index.ts
@@ -13,6 +13,8 @@ export { METRIC_TYPE };
 
 type TrackFn = (type: UiStatsMetricType, event: string | string[], count?: number) => void;
 
+const noop = () => {};
+
 let _track: TrackFn;
 
 export const track: TrackFn = (type, event, count) => {
@@ -25,9 +27,9 @@ export const track: TrackFn = (type, event, count) => {
 
 export const initTelemetry = (usageCollection: SetupPlugins['usageCollection'], appId: string) => {
   try {
-    _track = usageCollection.reportUiStats.bind(null, appId);
+    _track = usageCollection?.reportUiStats.bind(null, appId) ?? noop;
   } catch (error) {
-    // ignore failed setup here, as we'll just have an inert tracker
+    _track = noop;
   }
 };
 

diff --git a/x-pack/plugins/siem/public/plugin.tsx b/x-pack/plugins/siem/public/plugin.tsx
@@ -37,7 +37,7 @@ export interface SetupPlugins {
   home: HomePublicPluginSetup;
   security: SecurityPluginSetup;
   triggers_actions_ui: TriggersActionsSetup;
-  usageCollection: UsageCollectionSetup;
+  usageCollection?: UsageCollectionSetup;
 }
 
 export interface StartPlugins {