[Discover] Unskip functional saved queries test

elastic · Apr 19, 2021 · 7c5f41e · 7c5f41e
1 parent efcf7d1
commit 7c5f41e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 14 deletions.
diff --git a/test/functional/apps/discover/_saved_queries.ts b/test/functional/apps/discover/_saved_queries.ts
@@ -26,8 +26,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const savedQueryManagementComponent = getService('savedQueryManagementComponent');
   const testSubjects = getService('testSubjects');
 
-  // Failing: See https://github.com/elastic/kibana/issues/89477
-  describe.skip('saved queries saved objects', function describeIndexTests() {
+  describe('saved queries saved objects', function describeIndexTests() {
     before(async function () {
       log.debug('load kibana index with default index pattern');
       await esArchiver.load('discover');
@@ -134,10 +133,6 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await savedQueryManagementComponent.saveNewQueryWithNameError('OkResponse');
       });
 
-      it('does not allow saving a query with leading or trailing whitespace in the name', async () => {
-        await savedQueryManagementComponent.saveNewQueryWithNameError('OkResponse ');
-      });
-
       it('resets any changes to a loaded query on reloading the same saved query', async () => {
         await savedQueryManagementComponent.loadSavedQuery('OkResponse');
         await queryBar.setQuery('response:503');

diff --git a/test/functional/services/saved_query_management_component.ts b/test/functional/services/saved_query_management_component.ts
@@ -50,15 +50,14 @@ export function SavedQueryManagementComponentProvider({
       // an error.
       await testSubjects.click('savedQueryFormSaveButton');
 
-      const saveQueryFormSaveButtonStatus = await testSubjects.isEnabled(
-        'savedQueryFormSaveButton'
-      );
+      await retry.waitForWithTimeout('save button to be disabled', 1000, async () => {
+        const saveQueryFormSaveButtonStatus = await testSubjects.isEnabled(
+          'savedQueryFormSaveButton'
+        );
+        return saveQueryFormSaveButtonStatus === false;
+      });
 
-      try {
-        expect(saveQueryFormSaveButtonStatus).to.not.eql(true);
-      } finally {
-        await testSubjects.click('savedQueryFormCancelButton');
-      }
+      await testSubjects.click('savedQueryFormCancelButton');
     }
 
     public async saveCurrentlyLoadedAsNewQuery(