🔇 Remove debugging logs

elastic · Aug 4, 2020 · 688576c · 688576c
1 parent d5025d4
commit 688576c
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 14 deletions.
diff --git a/src/plugins/embeddable/public/lib/containers/container.ts b/src/plugins/embeddable/public/lib/containers/container.ts
@@ -217,9 +217,6 @@ export abstract class Container<
       throw new PanelNotFoundError();
     }
     const panelState: PanelState = this.input.panels[embeddableId];
-    if (!panelState.explicitInput) {
-      // console.log('No data in here!', embeddableId, panelState);
-    }
     return panelState as PanelState<TEmbeddableInput>;
   }
 

diff --git a/src/plugins/embeddable/public/lib/panel/embeddable_panel.tsx b/src/plugins/embeddable/public/lib/panel/embeddable_panel.tsx
@@ -125,15 +125,9 @@ export class EmbeddablePanel extends React.Component<Props, State> {
   }
 
   private async refreshNotifications() {
-    let notifications;
-    // TODO: remove this try/catch
-    try {
-      notifications = await this.props.getActions(PANEL_NOTIFICATION_TRIGGER, {
-        embeddable: this.props.embeddable,
-      });
-    } catch (e) {
-      return;
-    }
+    let notifications = await this.props.getActions(PANEL_NOTIFICATION_TRIGGER, {
+      embeddable: this.props.embeddable,
+    });
     if (!this.mounted) return;
 
     const { disabledActions } = this.props.embeddable.getInput();

diff --git a/x-pack/plugins/embeddable_enhanced/public/actions/panel_notifications_action.ts b/x-pack/plugins/embeddable_enhanced/public/actions/panel_notifications_action.ts
@@ -48,8 +48,6 @@ export class PanelNotificationsAction implements ActionDefinition<EnhancedEmbedd
 
   public readonly isCompatible = async ({ embeddable }: EnhancedEmbeddableContext) => {
     if (embeddable.getInput().viewMode !== ViewMode.EDIT) return false;
-    // TODO: remove this later on
-    if (!embeddable.enhancements) return false;
     return this.getEventCount(embeddable) > 0;
   };