[ResponseOps][rule registry] Remove usages of refresh: true (#159252)

Resolves #158139 ## Summary Removes refresh: true from the rule registry ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
elastic · Jun 12, 2023 · 679dc80 · 679dc80
1 parent 3164006
commit 679dc80
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts b/x-pack/plugins/rule_registry/server/alert_data_client/alerts_client.ts
@@ -789,7 +789,6 @@ export class AlertsClient {
         const result = await this.esClient.updateByQuery({
           index,
           conflicts: 'proceed',
-          refresh: true,
           body: {
             script: {
               source: `if (ctx._source['${ALERT_WORKFLOW_STATUS}'] != null) {
@@ -929,7 +928,6 @@ export class AlertsClient {
       await this.esClient.updateByQuery({
         index,
         conflicts: 'proceed',
-        refresh: true,
         body: {
           script: {
             source: painlessScript,

diff --git a/x-pack/plugins/rule_registry/server/alert_data_client/tests/remove_cases_from_alerts.test.ts b/x-pack/plugins/rule_registry/server/alert_data_client/tests/remove_cases_from_alerts.test.ts
@@ -164,7 +164,6 @@ describe('remove cases from alerts', () => {
           "conflicts": "proceed",
           "ignore_unavailable": true,
           "index": "undefined-*",
-          "refresh": true,
         }
       `);
     });

diff --git a/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts b/x-pack/plugins/rule_registry/server/utils/create_persistence_rule_type_wrapper.ts
@@ -355,7 +355,7 @@ export const createPersistenceRuleTypeWrapper: CreatePersistenceRuleTypeWrapper
 
                 const bulkResponse = await ruleDataClientWriter.bulk({
                   body: [...duplicateAlertUpdates, ...mapAlertsToBulkCreate(augmentedAlerts)],
-                  refresh: true,
+                  refresh: 'wait_for',
                 });
 
                 if (bulkResponse == null) {